Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix receivers config unit tests #594

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

fuwx295
Copy link
Contributor

@fuwx295 fuwx295 commented Nov 15, 2023

Description

When reading kindling-collector-config.yaml file, if there are no receivers, the default receivers configuration will not take effect and will be empty. If there are receviers, it can be read normally.

How Has This Been Tested?

Test the case where the profile receiver is empty.

Expected results

If empty it will output the default configuration.

Test results

Configuration found to be empty and not as expected。
image

@dxsup
Copy link
Member

dxsup commented Nov 17, 2023

This PR can't fix 593, only fix the unit tests. Please remove the correlation with that issue.

@dxsup
Copy link
Member

dxsup commented Nov 17, 2023

Please fix the DCO check.

@fuwx295 fuwx295 changed the title fix receivers config bug fix receivers config unit tests Nov 17, 2023
@fuwx295
Copy link
Contributor Author

fuwx295 commented Nov 17, 2023

@dxsup ok

@dxsup dxsup merged commit 397ddeb into KindlingProject:main Nov 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants