Skip to content

Commit

Permalink
Bug 16154: CGI->multi_param - Declare a list
Browse files Browse the repository at this point in the history 
This patch replaces the occurrences of
  my @foo = $cgi->param('foo');
with
  my @foo = $cgi->multi_param('foo');

perl -p -i -e
's/^(\s*my\s*@\w+\s*=\s*)\$(cgi|input|query)\->param\(/$1\$$2\->multi_param\(/xms'
**/*.pl

Signed-off-by: Owen Leonard <[email protected]>
Signed-off-by: Katrin Fischer <[email protected]>

Signed-off-by: Brendan Gallagher <[email protected]>
  • Loading branch information
@joubu @brendan1226
joubu authored and brendan1226 committed Apr 26, 2016
1 parent 080ae7a commit 66aacac
Show file tree
Hide file tree
Showing 80 changed files with 229 additions and 229 deletions.
14 changes: 7 additions & 7 deletions acqui/addorder.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -280,13 +280,13 @@ =head1 CGI PARAMETERS
# now, add items if applicable
if (C4::Context->preference('AcqCreateItem') eq 'ordering') {

my @tags = $input->param('tag');
my @subfields = $input->param('subfield');
my @field_values = $input->param('field_value');
my @serials = $input->param('serial');
my @itemid = $input->param('itemid');
my @ind_tag = $input->param('ind_tag');
my @indicator = $input->param('indicator');
my @tags = $input->multi_param('tag');
my @subfields = $input->multi_param('subfield');
my @field_values = $input->multi_param('field_value');
my @serials = $input->multi_param('serial');
my @itemid = $input->multi_param('itemid');
my @ind_tag = $input->multi_param('ind_tag');
my @indicator = $input->multi_param('indicator');
#Rebuilding ALL the data for items into a hash
# parting them on $itemid.

Expand Down
26 changes: 13 additions & 13 deletions acqui/addorderiso2709.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -133,13 +133,13 @@
my $biblios = GetImportRecordsRange($import_batch_id);
my $duplinbatch;
my $imported = 0;
my @import_record_id_selected = $input->param("import_record_id");
my @quantities = $input->param('quantity');
my @prices = $input->param('price');
my @budgets_id = $input->param('budget_id');
my @discount = $input->param('discount');
my @sort1 = $input->param('sort1');
my @sort2 = $input->param('sort2');
my @import_record_id_selected = $input->multi_param("import_record_id");
my @quantities = $input->multi_param('quantity');
my @prices = $input->multi_param('price');
my @budgets_id = $input->multi_param('budget_id');
my @discount = $input->multi_param('discount');
my @sort1 = $input->multi_param('sort1');
my @sort2 = $input->multi_param('sort2');
my $active_currency = Koha::Acquisition::Currencies->get_active;
for my $biblio (@$biblios){
# Check if this import_record_id was selected
Expand Down Expand Up @@ -239,12 +239,12 @@
# parse the item sent by the form, and create an item just for the import_record_id we are dealing with
# this is not optimised, but it's working !
if ( C4::Context->preference('AcqCreateItem') eq 'ordering' ) {
my @tags = $input->param('tag');
my @subfields = $input->param('subfield');
my @field_values = $input->param('field_value');
my @serials = $input->param('serial');
my @ind_tag = $input->param('ind_tag');
my @indicator = $input->param('indicator');
my @tags = $input->multi_param('tag');
my @subfields = $input->multi_param('subfield');
my @field_values = $input->multi_param('field_value');
my @serials = $input->multi_param('serial');
my @ind_tag = $input->multi_param('ind_tag');
my @indicator = $input->multi_param('indicator');
my $item;
push @{ $item->{tags} }, $tags[0];
push @{ $item->{subfields} }, $subfields[0];
Expand Down
2 changes: 1 addition & 1 deletion acqui/basketgroup.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ sub generate_edifact_orders {
#
# Getting parameters
my $basketgroup = {};
my @baskets = $input->param('basket');
my @baskets = $input->multi_param('basket');
my $basketgroupid = $input->param('basketgroupid');
my $basketgroupname = $input->param('basketgroupname');
my $booksellerid = $input->param('booksellerid');
Expand Down
2 changes: 1 addition & 1 deletion acqui/check_duplicate_barcode_ajax.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
my $json;

#Check if the barcodes already exist.
my @barcodes = $input->param('barcodes');
my @barcodes = $input->multi_param('barcodes');
foreach my $barcode (@barcodes) {
my $existing_itemnumber = GetItemnumberFromBarcode($barcode);
if ($existing_itemnumber) {
Expand Down
4 changes: 2 additions & 2 deletions acqui/check_uniqueness.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
use C4::Items;

my $input = new CGI;
my @field = $input->param('field[]');
my @value = $input->param('value[]');
my @field = $input->multi_param('field[]');
my @value = $input->multi_param('value[]');

my $r = {};
my $i = 0;
Expand Down
14 changes: 7 additions & 7 deletions acqui/finishreceive.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,13 @@
# now, add items if applicable
if (C4::Context->preference('AcqCreateItem') eq 'receiving') {

my @tags = $input->param('tag');
my @subfields = $input->param('subfield');
my @field_values = $input->param('field_value');
my @serials = $input->param('serial');
my @itemid = $input->param('itemid');
my @ind_tag = $input->param('ind_tag');
my @indicator = $input->param('indicator');
my @tags = $input->multi_param('tag');
my @subfields = $input->multi_param('subfield');
my @field_values = $input->multi_param('field_value');
my @serials = $input->multi_param('serial');
my @itemid = $input->multi_param('itemid');
my @ind_tag = $input->multi_param('ind_tag');
my @indicator = $input->multi_param('indicator');
#Rebuilding ALL the data for items into a hash
# parting them on $itemid.
my %itemhash;
Expand Down
2 changes: 1 addition & 1 deletion acqui/histsearch.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ =head1 CGI PARAMETERS
my $orderstatus = $input->param( 'orderstatus' );
my $ordernumber = $input->param( 'ordernumber' );
my $search_children_too = $input->param( 'search_children_too' );
my @created_by = $input->param('created_by');
my @created_by = $input->multi_param('created_by');

my $from_placed_on = eval { dt_from_string( $input->param('from') ) } || dt_from_string;
my $to_placed_on = eval { dt_from_string( $input->param('to') ) } || dt_from_string;
Expand Down
2 changes: 1 addition & 1 deletion acqui/invoice.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ =head1 DESCRIPTION
} elsif ($input->param('close')) {
CloseInvoice($invoiceid);
} elsif ($input->param('merge')) {
my @sources = $input->param('merge');
my @sources = $input->multi_param('merge');
MergeInvoices($invoiceid, \@sources);
defined($invoice_files) && $invoice_files->MergeFileRecIds(@sources);
}
Expand Down
2 changes: 1 addition & 1 deletion acqui/lateorders-export.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
authnotrequired => 0,
flagsrequired => {acquisition => 'order_receive'},
});
my @ordernumbers = $input->param('ordernumber');
my @ordernumbers = $input->multi_param('ordernumber');

my @orders;
for my $ordernumber ( @ordernumbers ) {
Expand Down
2 changes: 1 addition & 1 deletion acqui/lateorders.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ =head1 CGI PARAMETERS
}

if ($op and $op eq "send_alert"){
my @ordernums = $input->param("ordernumber");# FIXME: Fallback values?
my @ordernums = $input->multi_param("ordernumber");# FIXME: Fallback values?
my $err;
eval {
$err = SendAlerts( 'claimacquisition', \@ordernums, $input->param("letter_code") ); # FIXME: Fallback value?
Expand Down
2 changes: 1 addition & 1 deletion acqui/z3950_search.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
exit;
}

my @id = $input->param('id');
my @id = $input->multi_param('id');
if (@id==0) {
$template->param( emptyserverlist => 1 );
output_html_with_http_headers $input, $cookie, $template->output;
Expand Down
4 changes: 2 additions & 2 deletions admin/aqplan.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@

my $show_mine = $input->param('show_mine') ;

my @hide_cols = $input->param('hide_cols');
my @hide_cols = $input->multi_param('hide_cols');

if ( $budget_period_locked == 1 && not defined $show_actual ) {
$show_actual = 1;
Expand Down Expand Up @@ -141,7 +141,7 @@
my @authvals;
my %labels;

my @names = $input->param();
my @names = $input->multi_param();
# ------------------------------------------------------------
if ( $op eq 'save' ) {
#get budgets
Expand Down
2 changes: 1 addition & 1 deletion admin/audio_alerts.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
my $id = $cgi->param('id');
my $action = $cgi->param('action');
my $where = $cgi->param('where');
my @delete = $cgi->param('delete');
my @delete = $cgi->multi_param('delete');

my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
Expand Down
20 changes: 10 additions & 10 deletions admin/auth_subfields_structure.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -192,18 +192,18 @@ sub auth_subfield_structure_exists {
values (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)");
my $sth_update = $dbh->prepare("update auth_subfield_structure set authtypecode=?, tagfield=?, tagsubfield=?, liblibrarian=?, libopac=?, repeatable=?, mandatory=?, kohafield=?, tab=?, seealso=?, authorised_value=?, frameworkcode=?, value_builder=?, hidden=?, isurl=?, defaultvalue=?
where authtypecode=? and tagfield=? and tagsubfield=?");
my @tagsubfield = $input->param('tagsubfield');
my @liblibrarian = $input->param('liblibrarian');
my @libopac = $input->param('libopac');
my @tagsubfield = $input->multi_param('tagsubfield');
my @liblibrarian = $input->multi_param('liblibrarian');
my @libopac = $input->multi_param('libopac');
my @kohafield = ''.$input->param('kohafield');
my @tab = $input->param('tab');
my @seealso = $input->param('seealso');
my @ohidden = $input->param('ohidden');
my @authorised_values = $input->param('authorised_value');
my @tab = $input->multi_param('tab');
my @seealso = $input->multi_param('seealso');
my @ohidden = $input->multi_param('ohidden');
my @authorised_values = $input->multi_param('authorised_value');
my $authtypecode = $input->param('authtypecode');
my @frameworkcodes = $input->param('frameworkcode');
my @value_builder =$input->param('value_builder');
my @defaultvalue = $input->param('defaultvalue');
my @frameworkcodes = $input->multi_param('frameworkcode');
my @value_builder =$input->multi_param('value_builder');
my @defaultvalue = $input->multi_param('defaultvalue');
for (my $i=0; $i<= $#tagsubfield ; $i++) {
my $tagfield =$input->param('tagfield');
my $tagsubfield =$tagsubfield[$i];
Expand Down
2 changes: 1 addition & 1 deletion admin/columns_settings.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

if ( $action eq 'save' ) {
my $module = $input->param('module');
my @columnids = $input->param("columnid");
my @columnids = $input->multi_param("columnid");
my @columns;
for my $columnid (@columnids) {
next unless $columnid =~ m|^([^#]*)#([^#]*)#(.*)$|;
Expand Down
26 changes: 13 additions & 13 deletions admin/marc_subfields_structure.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -249,19 +249,19 @@ sub marc_subfield_structure_exists {
update marc_subfield_structure set tagfield=?, tagsubfield=?, liblibrarian=?, libopac=?, repeatable=?, mandatory=?, kohafield=?, tab=?, seealso=?, authorised_value=?, authtypecode=?, value_builder=?, hidden=?, isurl=?, frameworkcode=?, link=?, defaultvalue=?, maxlength=?
where tagfield=? and tagsubfield=? and frameworkcode=?
});
my @tagsubfield = $input->param('tagsubfield');
my @liblibrarian = $input->param('liblibrarian');
my @libopac = $input->param('libopac');
my @kohafield = $input->param('kohafield');
my @tab = $input->param('tab');
my @seealso = $input->param('seealso');
my @hidden = $input->param('hidden');
my @authorised_values = $input->param('authorised_value');
my @authtypecodes = $input->param('authtypecode');
my @value_builder = $input->param('value_builder');
my @link = $input->param('link');
my @defaultvalue = $input->param('defaultvalue');
my @maxlength = $input->param('maxlength');
my @tagsubfield = $input->multi_param('tagsubfield');
my @liblibrarian = $input->multi_param('liblibrarian');
my @libopac = $input->multi_param('libopac');
my @kohafield = $input->multi_param('kohafield');
my @tab = $input->multi_param('tab');
my @seealso = $input->multi_param('seealso');
my @hidden = $input->multi_param('hidden');
my @authorised_values = $input->multi_param('authorised_value');
my @authtypecodes = $input->multi_param('authtypecode');
my @value_builder = $input->multi_param('value_builder');
my @link = $input->multi_param('link');
my @defaultvalue = $input->multi_param('defaultvalue');
my @maxlength = $input->multi_param('maxlength');

for ( my $i = 0 ; $i <= $#tagsubfield ; $i++ ) {
my $tagfield = $input->param('tagfield');
Expand Down
8 changes: 4 additions & 4 deletions admin/oai_set_mappings.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ =head1 DESCRIPTION
my $op = $input->param('op');

if($op && $op eq "save") {
my @marcfields = $input->param('marcfield');
my @marcsubfields = $input->param('marcsubfield');
my @operators = $input->param('operator');
my @marcvalues = $input->param('marcvalue');
my @marcfields = $input->multi_param('marcfield');
my @marcsubfields = $input->multi_param('marcsubfield');
my @operators = $input->multi_param('operator');
my @marcvalues = $input->multi_param('marcvalue');

my @mappings;
my $i = 0;
Expand Down
4 changes: 2 additions & 2 deletions admin/oai_sets.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ =head1 DESCRIPTION
} elsif($op && $op eq "savenew") {
my $spec = $input->param('spec');
my $name = $input->param('name');
my @descriptions = $input->param('description');
my @descriptions = $input->multi_param('description');
AddOAISet({
spec => $spec,
name => $name,
Expand All @@ -72,7 +72,7 @@ =head1 DESCRIPTION
my $id = $input->param('id');
my $spec = $input->param('spec');
my $name = $input->param('name');
my @descriptions = $input->param('description');
my @descriptions = $input->multi_param('description');
ModOAISet({
id => $id,
spec => $spec,
Expand Down
2 changes: 1 addition & 1 deletion admin/patron-attr-types.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ sub add_update_attribute_type {
$attr_type->display_checkout($display_checkout);
$attr_type->category_code($input->param('category_code'));
$attr_type->class($input->param('class'));
my @branches = $input->param('branches');
my @branches = $input->multi_param('branches');
$attr_type->branches( \@branches );

if ($op eq 'edit') {
Expand Down
10 changes: 5 additions & 5 deletions authorities/auth_finder.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@

# If search form posted
if ( $op eq "do_search" ) {
my @marclist = $query->param('marclist');
my @and_or = $query->param('and_or');
my @excluding = $query->param('excluding');
my @operator = $query->param('operator');
my @marclist = $query->multi_param('marclist');
my @and_or = $query->multi_param('and_or');
my @excluding = $query->multi_param('excluding');
my @operator = $query->multi_param('operator');
my @value = (
$query->param('value_mainstr') || undef,
$query->param('value_main') || undef,
Expand All @@ -84,7 +84,7 @@
my @field_data = ();

# get marclist again, as the previous one has been modified by catalogsearch (mainentry replaced by field name)
my @marclist_ini = $query->param('marclist');
my @marclist_ini = $query->multi_param('marclist');
for ( my $i = 0 ; $i <= $#marclist ; $i++ ) {
push @field_data, { term => "marclist", val => $marclist_ini[$i] };
push @field_data, { term => "and_or", val => $and_or[$i] };
Expand Down
10 changes: 5 additions & 5 deletions authorities/authorities.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -606,12 +606,12 @@ sub build_hidden_data {
if ($op eq "add") {
#------------------------------------------------------------------------------------------------------------------------------
# rebuild
my @tags = $input->param('tag');
my @subfields = $input->param('subfield');
my @values = $input->param('field_value');
my @tags = $input->multi_param('tag');
my @subfields = $input->multi_param('subfield');
my @values = $input->multi_param('field_value');
# build indicator hash.
my @ind_tag = $input->param('ind_tag');
my @indicator = $input->param('indicator');
my @ind_tag = $input->multi_param('ind_tag');
my @indicator = $input->multi_param('indicator');
my $record = TransformHtmlToMarc($input, 0);

my ($duplicateauthid,$duplicateauthvalue);
Expand Down
2 changes: 1 addition & 1 deletion authorities/merge.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
use C4::Biblio;

my $input = new CGI;
my @authid = $input->param('authid');
my @authid = $input->multi_param('authid');
my $merge = $input->param('merge');

my @errors;
Expand Down
8 changes: 4 additions & 4 deletions authorities/ysearch.pl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@ =head1 ysearch.pl
exit 0;
}

my @value = $query->param('term');
my @value = $query->multi_param('term');
my $searchtype = $query->param('querytype');
my @marclist = ($searchtype);
my $authtypecode = $query->param('authtypecode');
my @and_or = $query->param('and_or');
my @excluding = $query->param('excluding');
my @operator = $query->param('operator');
my @and_or = $query->multi_param('and_or');
my @excluding = $query->multi_param('excluding');
my @operator = $query->multi_param('operator');
my $orderby = $query->param('orderby');

my $resultsperpage = 50;
Expand Down
Loading

0 comments on commit 66aacac

Please sign in to comment.