Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project endpoints #297

Merged
merged 23 commits into from
Dec 31, 2024
Merged

Add project endpoints #297

merged 23 commits into from
Dec 31, 2024

Conversation

AmirAgassi
Copy link
Member

@AmirAgassi AmirAgassi commented Dec 27, 2024 •
edited
Loading

Description

Added all project related endpoints including create, get, list, submit for review, upload/delete documents, and patch answers. Added validation for required fields and file uploads, with proper error handling and response formatting.

Linked Issues

Testing

  • backend\internal\tests\server_test.go

Checklist

Before opening this PR, make sure the PR:

  • Has an assignee or group of assignees.
  • Has a reviewer or a group of reviewers.
  • Is labelled properly.
  • Has the SPUR project assigned to it.
  • Has an assigned milestone.

Additionally, make sure that:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@AmirAgassi AmirAgassi added backend Related to the backend of the project api Related to the backend routes and endpoints labels Dec 27, 2024
@AmirAgassi AmirAgassi added this to the Complete the project MVP milestone Dec 27, 2024
@AmirAgassi AmirAgassi self-assigned this Dec 27, 2024
@AmirAgassi AmirAgassi marked this pull request as draft December 27, 2024 01:59
@SherRao SherRao added the enhancement New feature or request label Dec 27, 2024
@AmirAgassi AmirAgassi marked this pull request as ready for review December 27, 2024 04:40
juancwu
juancwu reviewed Dec 28, 2024
View reviewed changes
backend/.sqlc/migrations/20241226195458_add_default_questions.sql Outdated Show resolved Hide resolved
backend/.sqlc/queries/projects.sql Outdated Show resolved Hide resolved
backend/.sqlc/queries/projects.sql Outdated Show resolved Hide resolved
backend/internal/v1/v1_projects/projects.go Outdated Show resolved Hide resolved
juancwu
juancwu reviewed Dec 28, 2024
View reviewed changes
backend/internal/tests/server_test.go Show resolved Hide resolved
backend/internal/tests/server_test.go Show resolved Hide resolved
backend/internal/v1/v1_projects/types.go Show resolved Hide resolved
backend/internal/middleware/jwt.go Outdated Show resolved Hide resolved
@juancwu
Copy link
Contributor

juancwu commented Dec 29, 2024

Overall, the only important change is to add authorization checks for the actions

juancwu
juancwu approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@juancwu juancwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AmirAgassi AmirAgassi merged commit c90299e into main Dec 31, 2024
4 checks passed
@AmirAgassi AmirAgassi deleted the feat/218/add-project-endpoints branch December 31, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancwu juancwu juancwu approved these changes

@aidantrabs aidantrabs Awaiting requested review from aidantrabs

Assignees

@AmirAgassi AmirAgassi

Labels
api Related to the backend routes and endpoints backend Related to the backend of the project enhancement New feature or request
Projects
SPUR Platform
Status: Done
Milestone
Complete the project MVP
3 participants
@AmirAgassi @juancwu @SherRao