Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create company endpoints #315

Merged
merged 14 commits into from
Jan 1, 2025
Merged

Create company endpoints #315

merged 14 commits into from
Jan 1, 2025

Conversation

aidantrabs
Copy link
Member

@aidantrabs aidantrabs commented Dec 30, 2024 •
edited
Loading

Description

  • Created company endpoints with ownership validation and role-based action control
  • Note: Does not implement a deletion of a company

Linked Issues

Testing

Checklist

Before opening this PR, make sure the PR:

  • Has an assignee or group of assignees.
  • Has a reviewer or a group of reviewers.
  • Is labelled properly.
  • Has the SPUR project assigned to it.
  • Has an assigned milestone.

Additionally, make sure that:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@aidantrabs aidantrabs added enhancement New feature or request backend Related to the backend of the project api Related to the backend routes and endpoints labels Dec 30, 2024
@aidantrabs aidantrabs added this to the Complete the project MVP milestone Dec 30, 2024
@aidantrabs aidantrabs self-assigned this Dec 30, 2024
AmirAgassi
AmirAgassi previously approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@AmirAgassi AmirAgassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

AmirAgassi
AmirAgassi approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@AmirAgassi AmirAgassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm 🔥

@aidantrabs aidantrabs merged commit c0da291 into main Jan 1, 2025
4 checks passed
@aidantrabs aidantrabs deleted the feat/190-192/create-company-endpoints branch January 1, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmirAgassi AmirAgassi AmirAgassi approved these changes

@juancwu juancwu Awaiting requested review from juancwu

Assignees

@aidantrabs aidantrabs

Labels
api Related to the backend routes and endpoints backend Related to the backend of the project enhancement New feature or request
Projects
SPUR Platform
Status: Done
Milestone
Complete the project MVP
2 participants
@aidantrabs @AmirAgassi