Fix AnchorLinks last link not mark as active if target is at end of page #316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue where the last link is never marked as active if the target element is right at the end of the page. The abnormal behaviour was that the second to last link is always the one marked as active because the AnchorLinks component chooses the closest one to the top when multiple targets are in view.
Linked Issues
Testing
components/test/AnchorLinks.test.tsx
jsDom
does not implement layouts.Checklist
Before opening this PR, make sure the PR:
Additionally, make sure that: