Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sectioned layout for project submission & view submitted project #339

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

juancwu
Copy link
Contributor

@juancwu juancwu commented Jan 17, 2025

Description

Add a new sectioned layout/template that is used on the project form and also viewing submitted project. The layout/template consists of two parts:

  1. The aside part where the anchor links or sections live. Those are clickable and auto highlight when the section is in view.
  2. The main center part where the main content should be.

Linked Issues

Screenshots

image

(Refer to the Figma designs for a better view, Project Form and Reviewing Project)

Checklist

Before opening this PR, make sure the PR:

  • Has an assignee or group of assignees.
  • Has a reviewer or a group of reviewers.
  • Is labelled properly.
  • Has the SPUR project assigned to it.
  • Has an assigned milestone.

Additionally, make sure that:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

this is to showcase the look of the SectionedLayout, and the landing
page was already like that so...
@juancwu juancwu added enhancement New feature or request frontend Related to the frontend of the project labels Jan 17, 2025
@juancwu juancwu added this to the Complete the project MVP milestone Jan 17, 2025
@juancwu juancwu self-assigned this Jan 17, 2025
@juancwu juancwu linked an issue Jan 17, 2025 that may be closed by this pull request
4 tasks
Copy link
Member

@aidantrabs aidantrabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juancwu juancwu merged commit 561c09e into main Jan 17, 2025
4 checks passed
@juancwu juancwu deleted the feat/333/sectioned-layout branch January 17, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to the frontend of the project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FE Feat] Create project form view layout template
2 participants