Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Creation Component #397

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Comment Creation Component #397

merged 4 commits into from
Feb 4, 2025

Conversation

aidantrabs
Copy link
Member

@aidantrabs aidantrabs commented Feb 4, 2025 •
edited
Loading

Description

Component to create a comment + service to create comment.

  • Formatting buttons aren't fully functional yet, but good for demo.

Linked Issues

Checklist

Before opening this PR, make sure the PR:

  • Has an assignee or group of assignees.
  • Has a reviewer or a group of reviewers.
  • Is labelled properly.
  • Has the SPUR project assigned to it.
  • Has an assigned milestone.

Additionally, make sure that:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@aidantrabs aidantrabs added enhancement New feature or request frontend Related to the frontend of the project api Related to the backend routes and endpoints labels Feb 4, 2025
@aidantrabs aidantrabs added this to the Complete the project MVP milestone Feb 4, 2025
@aidantrabs aidantrabs self-assigned this Feb 4, 2025
juancwu
juancwu previously approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@juancwu juancwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aidantrabs aidantrabs dismissed juancwu’s stale review February 4, 2025 01:08

The merge-base changed after approval.

juancwu
juancwu approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@juancwu juancwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aidantrabs aidantrabs merged commit dfae9df into main Feb 4, 2025
3 of 4 checks passed
@aidantrabs aidantrabs deleted the feat/387/comment-create-component branch February 4, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancwu juancwu juancwu approved these changes

@AmirAgassi AmirAgassi Awaiting requested review from AmirAgassi

Assignees

@aidantrabs aidantrabs

Labels
api Related to the backend routes and endpoints enhancement New feature or request frontend Related to the frontend of the project
Projects
Onboard by SPUR
Status: Done
Milestone
Complete the project MVP
Development

Successfully merging this pull request may close these issues.

[FE Feat] Create the comment creation card component
2 participants
@aidantrabs @juancwu