Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1003 Removal of default security context UID setting #1004

Closed

Conversation

MarkusFlorian79
Copy link

@MarkusFlorian79 MarkusFlorian79 commented Feb 7, 2024

What this PR does / why we need it:

Does reapply a fix done in 1.6.0 This is the text form ./kong/UPGRADE.md:

Removal of default security context UID setting

Versions of Kong prior to 2.0 and Kong Enterprise prior to 1.3 use Docker
images that required setting a UID via Kubernetes in some environments
(primarily OpenShift). This is no longer necessary with modern Docker images
and can cause issues depending on other environment settings, so it was
removed.

Most users should not need to take any action, but if you encounter permissions
errors when upgrading (kubectl describe pod PODNAME should contain any), you
can restore it by adding the following to your values.yaml:

securityContext:
  runAsUser: 1000


#### Which issue this PR fixes
*(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*
  - fixes #1003 

#### Special notes for your reviewer:

#### Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
- [ ] PR is based off the current tip of the `main` branch.
- [ ] Changes are documented under the "Unreleased" header in CHANGELOG.md
- [ ] New or modified sections of values.yaml are documented in the README.md
- [ ] Commits follow the [Kong commit message guidelines](https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#commit-message-format)

@MarkusFlorian79 MarkusFlorian79 requested a review from a team as a code owner February 7, 2024 08:20
@CLAassistant
Copy link

CLAassistant commented Feb 7, 2024

CLA assistant check
All committers have signed the CLA.

@rainest
Copy link
Contributor

rainest commented Feb 7, 2024

Closing pending further investigation into whether we can satisfy both OpenShift's and base Kubernetes' desires here: #1003 (comment)

@rainest rainest closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants