Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rbac): Fix rbac for gwapi v1 #928

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix(rbac): Fix rbac for gwapi v1 #928

merged 2 commits into from
Nov 6, 2023

Conversation

pangruoran
Copy link
Contributor

@pangruoran pangruoran commented Nov 6, 2023

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

This PR includes two commits for easy cherry-picking if necessary.

  • fix RBAC for Gateway API v1
  • enable admission webhook for Gateway API v1

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
    - [ ] New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@pangruoran pangruoran requested a review from a team as a code owner November 6, 2023 03:29
@CLAassistant
Copy link

CLAassistant commented Nov 6, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pangruoran pangruoran force-pushed the fix-rbac-for-gwapi-v1 branch from dd0454f to 064150a Compare November 6, 2023 06:20
@pangruoran pangruoran merged commit 6c87209 into main Nov 6, 2023
22 checks passed
@pangruoran pangruoran deleted the fix-rbac-for-gwapi-v1 branch November 6, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(charts): lose RBAC configurations for GWAPI v1
5 participants