-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certificates and CA certificates: references #265
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongdeveloper ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lena-larionova
commented
Jan 16, 2025
lena-larionova
force-pushed
the
feat/certificates-how-to
branch
from
January 16, 2025 18:28
c60c663
to
8175348
Compare
lena-larionova
changed the title
Certificates and CA certificates: reference and how-to
Certificates and CA certificates: references
Jan 16, 2025
cloudjumpercat
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes needed:
- A few grammatical fixes and a few entity references were missing an inline link to the entity page.
- Two todo how tos are missing corresponding GH issues (or I couldn't find them).
- Change "SSL Certificate reference" title to something that hints more at use cases and quickly seeing how to setup SSL certs
- Descriptions from the "Configuring SSL connections through kong.conf" table should be moved to the kong.conf autogenerated source file. I'd prefer we link or use an autogenerated table instead of a manual table. This shouldn't hold up this PR though. We can note this to fix later and ship the table as-is.
Note: I also didn't test these code snippets since I read your note in the PR checklist about not knowing how to validate them.
Co-authored-by: Diana <[email protected]>
cloudjumpercat
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226
Fixes #238.
Created to-do task #278 to track how-to topics.
How-tos for service-level certs and ca certs and a reference doc for cert types in Gateway + fixes to cert and ca cert entities.
Need help figuring out how to properly test and validate. Creating the entities and applying them to Gateway works fine, the validation is difficult.
Few other things that need adjusting:
Preview Links
https://deploy-preview-265--kongdeveloper.netlify.app/gateway/entities/certificate/
https://deploy-preview-265--kongdeveloper.netlify.app/gateway/entities/ca-certificate/
https://deploy-preview-265--kongdeveloper.netlify.app/gateway/ssl-certificates/
Checklist