fix: fixing consumer-group related dump config for deck. #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With changes added in go-kong, to skip listing consumers while doing a GET call on a consumer_group, dump config with gw 3.9+ starting showing issues. Associations between a consumer and consumer-group were missing. Thus, we are pushing the no listing consumers feature behind a flag for now, applicable only for dump command as a starting point. This change adds a new config that can be set via a deck command flag. If set to true, it will not list consumers-consumer group associations in the dump file.
|
@Prashansa-K This flag should apply to diff and sync too. It’s suitable when consumers are being managed in a different file. By default, consumers should be included in all commands |
Alright. That should be fine for this PR. We should not require any more code changes to support the said flag with sync and diff. I will update the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With changes added in go-kong, to skip
listing consumers while doing a GET call
on a consumer_group, dump config with gw
3.9+ starting showing issues. Associations
between a consumer and consumer-group were
missing. Thus, we are pushing the no listing
consumers feature behind a flag for now.
This change adds a new config that can be
set via a deck command flag. If set to true,
it will not list consumers-consumer group
associations.
Depends on Kong/go-kong#494
Issues resolved
For Kong/deck#1483
Documentation
Testing