Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wasm filter-chain entity support #72

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

flrgh
Copy link
Contributor

@flrgh flrgh commented Mar 19, 2024

Note: requires Kong/go-kong#362

Summary

This adds support for the filter chain entity, added to Kong in 3.4.

Full changelog

  • Add gateway FilterChain

Issues resolved

KAG-4005
KOKO-1275

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2024

CLA assistant check
All committers have signed the CLA.

@flrgh flrgh force-pushed the feat/filter-chains branch 4 times, most recently from 237b1ac to ce68f6d Compare April 2, 2024 20:02
@flrgh flrgh force-pushed the feat/filter-chains branch 5 times, most recently from bb91ea4 to 96a88f6 Compare April 4, 2024 21:21
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 41.65202% with 332 lines in your changes are missing coverage. Please review.

Project coverage is 41.01%. Comparing base (54a82f6) to head (490f9bb).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/file/writer.go 17.34% 68 Missing and 13 partials ⚠️
pkg/file/types.go 34.21% 69 Missing and 6 partials ⚠️
pkg/file/builder.go 37.03% 42 Missing and 9 partials ⚠️
pkg/state/filter_chain.go 77.71% 25 Missing and 14 partials ⚠️
pkg/state/types.go 27.08% 35 Missing ⚠️
pkg/dump/dump.go 0.00% 28 Missing ⚠️
pkg/state/builder.go 0.00% 21 Missing ⚠️
pkg/diff/diff.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   40.89%   41.01%   +0.11%     
==========================================
  Files          73       74       +1     
  Lines       10202    10736     +534     
==========================================
+ Hits         4172     4403     +231     
- Misses       5612     5875     +263     
- Partials      418      458      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flrgh flrgh force-pushed the feat/filter-chains branch 3 times, most recently from 4ffc7af to 774ae9a Compare April 8, 2024 21:39
@flrgh flrgh changed the title [WIP] feat: add wasm filter-chain entity support feat: add wasm filter-chain entity support Apr 8, 2024
@flrgh flrgh marked this pull request as ready for review April 8, 2024 21:59
@flrgh flrgh requested a review from a team April 8, 2024 21:59
@flrgh flrgh force-pushed the feat/filter-chains branch 4 times, most recently from 865b999 to 3afd425 Compare April 9, 2024 17:31
@flrgh flrgh force-pushed the feat/filter-chains branch from 3fe53aa to dd2495e Compare April 19, 2024 22:22
@flrgh flrgh force-pushed the feat/filter-chains branch 7 times, most recently from a2cd404 to 593ebaa Compare May 8, 2024 21:12
@flrgh flrgh force-pushed the feat/filter-chains branch 4 times, most recently from 5417c37 to 23c366a Compare May 13, 2024 16:05
@flrgh flrgh force-pushed the feat/filter-chains branch from 23c366a to 490f9bb Compare May 13, 2024 16:13
@flrgh flrgh requested review from GGabriele and rainest May 13, 2024 16:15
@rainest rainest merged commit 0cc539e into main May 13, 2024
42 checks passed
@rainest rainest deleted the feat/filter-chains branch May 13, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants