Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider workspace in FillID method #393

Closed
randmonkey opened this issue Jan 3, 2024 · 1 comment
Closed

Consider workspace in FillID method #393

randmonkey opened this issue Jan 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@randmonkey
Copy link
Contributor

As investigated in Kong/kubernetes-ingress-controller#5389, the FillID() method may generate the same ID for different entities with same "key" in different workspaces. However, ID should be unique through ALL workspaces. This will bring conflicts in configurations.

For example, if two consumers in different workspaces have the same username, we will generate the same ID for the two consumers. Then one of them will receive a "ID already exist" error as described in Kong/kubernetes-ingress-controller#5389. To resolve this, we need to consider workspace of the entity to generate ID from.

@randmonkey
Copy link
Contributor Author

fixed in #395 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant