Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workspace param in FillID methods #395

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Jan 5, 2024

Add workspace parameter in FillID methods of supporting entities to avoid ID conflict on entities in different namespaces with the same "key". fixes #394.

@randmonkey randmonkey requested a review from a team as a code owner January 5, 2024 03:51
@randmonkey randmonkey requested a review from a team January 5, 2024 03:51
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec62201) 53.04% compared to head (3888dc3) 53.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   53.04%   53.07%   +0.03%     
==========================================
  Files          69       69              
  Lines        5243     5247       +4     
==========================================
+ Hits         2781     2785       +4     
  Misses       1876     1876              
  Partials      586      586              
Flag Coverage Δ
2.1 33.19% <100.00%> (+0.05%) ⬆️
2.2 44.57% <100.00%> (+0.04%) ⬆️
2.3 45.28% <100.00%> (+0.04%) ⬆️
2.4 45.35% <100.00%> (+0.04%) ⬆️
2.5 45.35% <100.00%> (+0.04%) ⬆️
2.6 45.35% <100.00%> (+0.04%) ⬆️
2.7 46.84% <100.00%> (+0.04%) ⬆️
2.8 46.84% <100.00%> (+0.04%) ⬆️
3.0 50.54% <100.00%> (+0.03%) ⬆️
3.1 51.99% <100.00%> (+0.03%) ⬆️
3.2 52.04% <100.00%> (+0.03%) ⬆️
3.3 52.04% <100.00%> (+0.03%) ⬆️
3.4 52.37% <100.00%> (+0.03%) ⬆️
community 38.38% <100.00%> (+0.04%) ⬆️
enterprise 51.76% <100.00%> (+0.03%) ⬆️
enterprise-nightly 50.73% <100.00%> (+0.03%) ⬆️
integration 53.07% <100.00%> (+0.03%) ⬆️
nightly 37.67% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randmonkey randmonkey force-pushed the fix/fill_id_add_workspace branch from 299855c to 3888dc3 Compare January 5, 2024 06:15
Copy link
Member

@programmer04 programmer04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the wrong issue referenced in the description of this PR, should be #393

@randmonkey randmonkey merged commit 72313bb into main Jan 5, 2024
67 checks passed
@randmonkey randmonkey deleted the fix/fill_id_add_workspace branch January 5, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants