-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle KongIngress
deprecation in admission webhook and in KongIngress
validation rules
#5022
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5022 +/- ##
=======================================
- Coverage 75.5% 75.5% -0.1%
=======================================
Files 167 167
Lines 18848 18836 -12
=======================================
- Hits 14238 14226 -12
- Misses 3783 3785 +2
+ Partials 827 825 -2
☔ View full report in Codecov by Sentry. |
8593f4d
to
f191145
Compare
1c5633a
to
7f85ca7
Compare
7f85ca7
to
35c62b6
Compare
KongIngress
deprecation in admission webhook and in KongIngress
validation rules
I've rebased the PR onto main and added CEL validations. |
35c62b6
to
8c6c952
Compare
Co-authored-by: Patryk Małek <[email protected]>
Co-authored-by: Patryk Małek <[email protected]>
b4648c0
to
057d0da
Compare
I had to rebase (conflict in go.sum), sorry @pmalek 😞 |
What this PR does / why we need it:
Alternative to #5015. Deprecates KongIngress in the sense that it's still available for the time being, but results in logs instructing users to migrate rather than removing it immediately.
Which issue this PR fixes:
For #4720 but not using auto-resolve since this isn't targeted to main.
Would need a follow-up "Remove KongIngress support" issue.
Notes:
I did leave in the checks for
route
andservice
even though CEL now blocks them. I figure it doesn't really hurt anything to have them there under normal circumstances, and we often had abnormal circumstances because users forget to update CRDs.Added a Service webhook handler also. I don't really love having that in place for such a common resource, but it is at least only temporary: we'd remove it once we actually remove KongIngress.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR