fix: set proper User-Agent for request made to Kong and Konnect #5753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmer04
added
the
area/maintenance
programmer04
changed the title
programmer04
force-pushed
the
user-agent
branch
from
5bbe397 to
7af779e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5753 +/- ##
=======================================
+ Coverage 73.4% 73.9% +0.5%
=======================================
Files 175 176 +1
Lines 18147 18172 +25
=======================================
+ Hits 13321 13440 +119
+ Misses 3851 3735 -116
- Partials 975 997 +22 ☔ View full report in Codecov by Sentry. |
programmer04
force-pushed
the
user-agent
branch
from
7af779e to
8934638
Compare
programmer04
force-pushed
the
user-agent
branch
3 times, most recently
from
2e37a20 to
c4c01c2
Compare
programmer04
force-pushed
the
user-agent
branch
from
c4c01c2 to
4ebbc52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It uses
go-kongfeature introduced inv0.52.0, seeIt allows setting
User-Agentto ensure that KIC always uses the client with the properUser-Agentset. The linter configuration will enforce it across the whole repo.For clients that live in the KIC repo
internal/konnect/*User-Agentis also added. Those clients are considered as a temporary solution because they will be deprecated as fast as the proper SDK will be released. Thus it's not in the scope of this PR to make a bigger refactor, etc. of those clients, just add the missingUser-Agent.Which issue this PR fixes:
Closes #5418
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR