Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue-2581] Fix bug showing withdrawal time on unstaking #2611

Merged
merged 20 commits into from
Mar 1, 2024
Merged

[Issue-2581] Fix bug showing withdrawal time on unstaking #2611

merged 20 commits into from
Mar 1, 2024

Conversation

bluezdot
Copy link

Related issue(s)

Is your feature request related to a problem(s)? Please describe.

  • Fix bug showing withdrawal time on unstaking

Describe the solution you'd like

  • Use activeEra instead of currentEra
  • Withdrawal at the start of target era instead of the end of target era

Describe alternatives you've considered

  • Consider if subscribing currentEra not update suitable on activeEra information

Additional context

  • No

@bluezdot bluezdot added the critical-error Critical error need to be fixed ASAP label Feb 16, 2024
@bluezdot bluezdot added this to the Milestone 7 milestone Feb 16, 2024
@bluezdot bluezdot requested a review from nampc1 February 16, 2024 02:01
@bluezdot bluezdot self-assigned this Feb 16, 2024
@saltict
Copy link

saltict commented Feb 16, 2024 •
edited
Loading

🚀 Deployed on https://pr-2611--sw-web-runner.netlify.app

@saltict saltict temporarily deployed to pull request February 16, 2024 02:10 Inactive
@bluezdot bluezdot linked an issue Feb 16, 2024 that may be closed by this pull request
Fix bug showing withdrawal time on unstaking #2581
Closed
@saltict saltict temporarily deployed to pull request February 21, 2024 10:56 Inactive
@saltict saltict temporarily deployed to pull request February 21, 2024 11:21 Inactive
@saltict saltict temporarily deployed to pull request February 21, 2024 11:55 Inactive
@saltict saltict temporarily deployed to pull request February 22, 2024 06:01 Inactive
@saltict saltict temporarily deployed to pull request February 22, 2024 13:03 Inactive
@saltict saltict temporarily deployed to pull request February 23, 2024 02:33 Inactive
@saltict saltict temporarily deployed to pull request February 23, 2024 09:53 Inactive
@saltict saltict temporarily deployed to pull request February 23, 2024 10:20 Inactive
@saltict saltict temporarily deployed to pull request February 29, 2024 04:29 Inactive
@S2kael S2kael force-pushed the koni/dev/issue-2581 branch from bbacb90 to df96339 Compare February 29, 2024 13:21
@saltict saltict temporarily deployed to pull request February 29, 2024 13:29 Inactive
@saltict saltict merged commit 99f0b86 into subwallet-dev Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saltict saltict saltict approved these changes

@nampc1 nampc1 nampc1 approved these changes

Assignees

@bluezdot bluezdot

Labels
critical-error Critical error need to be fixed ASAP
Projects
None yet
Milestone
Milestone 7
Development

Successfully merging this pull request may close these issues.

Fix bug showing withdrawal time on unstaking
4 participants
@bluezdot @saltict @nampc1 @S2kael