remove stupid error about erased self

KotlinIsland · Nov 29, 2024 · 1944461 · 1944461
1 parent 5d36e12
commit 1944461
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 4 deletions.
diff --git a/mypy/checker.py b/mypy/checker.py
@@ -1497,10 +1497,15 @@ def check_func_def(
                                     # the consistency check will be performed at call sites.
                                     msg = None
                                 elif typ.arg_names[i] in {"self", "cls"}:
-                                    msg = message_registry.ERASED_SELF_TYPE_NOT_SUPERTYPE.format(
-                                        erased.str_with_options(self.options),
-                                        ref_type.str_with_options(self.options),
-                                    )
+                                    if mypy.options._based:
+                                        msg = None
+                                    else:
+                                        msg = (
+                                            message_registry.ERASED_SELF_TYPE_NOT_SUPERTYPE.format(
+                                                erased.str_with_options(self.options),
+                                                ref_type.str_with_options(self.options),
+                                            )
+                                        )
                                 else:
                                     msg = message_registry.MISSING_OR_INVALID_SELF_TYPE
                                 if msg:

diff --git a/test-data/unit/check-based-misc.test b/test-data/unit/check-based-misc.test
@@ -235,3 +235,13 @@ class B(A):
 \[[tool.mypy.overrides]]
 module="other"
 work_not_properly_function_names=true
+
+
+[case testErasedSelfType]
+
+class A:
+    def f(self: B):
+        reveal_type(self) # N: Revealed type is "__main__.B"
+class B(A): ...
+A().f()  # E: Invalid self argument "A" to attribute function "f" with type "def (self: B) -> None"  [misc]
+B().f()  # no error