wip

basedtyping/__init__.py

@@ -680,10 +680,19 @@ def get_type_hints(
                 if value is None:
                     value = type(None)
                 if isinstance(value, str):
-                    value = ForwardRef(value, is_argument=False, is_class=True)
+                    # TODO: roll our own ForwardRef
+                    if sys.version_info < (3,9):
+                        value = ForwardRef(value, is_argument=False)
+                    else:
+                        value = ForwardRef(value, is_argument=False, is_class=True)
                 value = typing._eval_type(value, base_globals, base_locals)
                 hints[name] = value
-        return hints if include_extras else {k: typing._strip_annotations(t) for k, t in hints.items()}
+        if sys.version_info < (3,9):
+            def f(x):
+                return x
+        else:
+            f = typing._strip_annotations
+        return hints if include_extras else {k: f(t) for k, t in hints.items()}
 
     if globalns is None:
         if isinstance(obj, types.ModuleType):

tests/test_get_type_hints.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from basedtyping import get_type_hints
 
 def test_get_type_hints():
@@ -9,6 +11,6 @@ def __init_subclass__(cls, **kwargs):
 
 
     class A(Base):
-        a: A | None
+        a: A
 
-    assert result == {'a': A | None}
+    assert result == {'a': A}