Saving Cell Calls to the game file #299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, added Game.world:removeCall(name) and adjusted the functionality of Game.world:replaceCall(name, index (now old_name), scene)
SylviBlossom
requested changes
Dec 26, 2024
There was a problem hiding this comment.
This looks like a good system to me, however I'd suggest that, if changing and breaking the existing cell system, it should be moved out of World into Game directly, since it's static data and has nothing to do with the temporary world state, especially given it's saved to the file now.
To fit with the addition of removeCall, also consider renaming registerCall to addCall.
|
I've done the changes you requested |
|
@SylviBlossom The reason I kept it as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, added Game.world:removeCall(name), Game.world:clearCalls() and adjusted the functionality of Game.world:replaceCall(name, index, scene)
BREAKING CHANGE!!!