Skip to content

Commit

Permalink
fix(): add providedIn: 'root' to config service #244 - reported by @d…
Browse files Browse the repository at this point in the history
…reiquevada
  • Loading branch information
Ks89 committed Sep 27, 2021
1 parent 401ff0c commit 2363869
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 5 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
# 8.0.1

### Bugfixes

- fix `config.service.ts` adding `providedIn: 'root'` to the service (fixes #244) reported by @dreiquevada


# 8.0.0

### Features
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ You can use all default features without font-awesome. For more info, check offi

**More than 100 releases in two years**, and more to come... :)

- 09/27/2021 - 8.0.1 - @ks89/angular-modal-gallery - [HERE](https://github.com/Ks89/angular-modal-gallery/releases)
- 07/10/2021 - 8.0.0 - @ks89/angular-modal-gallery - [HERE](https://github.com/Ks89/angular-modal-gallery/releases)
- 06/13/2021 - 8.0.0-rc.1 - @ks89/angular-modal-gallery - [HERE](https://github.com/Ks89/angular-modal-gallery/releases)
- 11/22/2020 - 8.0.0-beta.5 - @ks89/angular-modal-gallery - [HERE](https://github.com/Ks89/angular-modal-gallery/releases)
Expand Down
1 change: 1 addition & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion projects/ks89/angular-modal-gallery/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ks89/angular-modal-gallery",
"version": "8.0.0",
"version": "8.0.1",
"description": "Image gallery for Angular",
"license": "MIT",
"author": "Stefano Cappa",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import { OverlayModule } from '@angular/cdk/overlay';
import { COMPONENTS, CarouselComponent } from './components/components';
import { PlainGalleryComponent } from './components/plain-gallery/plain-gallery.component';
import { DIRECTIVES } from './directives/directives';
import { ConfigService } from './services/config.service';

// to prevent bad scrolling behaviour on mobile phone with carousels.
// From @mohaxspb (https://github.com/Ks89/angular-modal-gallery/pull/187)
Expand All @@ -56,8 +55,7 @@ export class KsHammerGestureConfig extends HammerGestureConfig {
{
provide: HAMMER_GESTURE_CONFIG,
useClass: KsHammerGestureConfig
},
ConfigService
}
]
})
export class GalleryModule {}
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ const DEFAULT_CONFIG: LibConfig = Object.freeze({
/**
* Service to handle library configuration in a unique place
*/
@Injectable()
@Injectable({ providedIn: 'root' })
export class ConfigService {
configMap: Map<number, LibConfig> = new Map<number, LibConfig>();

Expand Down

0 comments on commit 2363869

Please sign in to comment.