Fix potential NPE in createRecipe with removed recipes

KubeJS-Mods · Jan 28, 2024 · 130a9dc · 130a9dc
1 parent cb41cea
commit 130a9dc
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/common/src/main/java/dev/latvian/mods/kubejs/recipe/RecipesEventJS.java b/common/src/main/java/dev/latvian/mods/kubejs/recipe/RecipesEventJS.java
@@ -399,12 +399,13 @@ public void post(RecipeManager recipeManager, Map<ResourceLocation, JsonElement>
 	private Recipe<?> createRecipe(RecipeJS r) {
 		try {
 			var rec = r.createRecipe();
+			var path = r.kjs$getMod() + "/" + r.getPath();
 
-			if (DataExport.export != null) {
-				DataExport.export.addJson("recipes/" + rec.getId() + ".json", r.json);
+			if (!r.removed && DataExport.export != null) {
+				DataExport.export.addJson("recipes/%s.json".formatted(path), r.json);
 
 				if (r.newRecipe) {
-					DataExport.export.addJson("added_recipes/" + rec.getId() + ".json", r.json);
+					DataExport.export.addJson("added_recipes/%s.json".formatted(path), r.json);
 				}
 			}