-
Notifications
You must be signed in to change notification settings - Fork 0
Distance sensors #97
base: master
Are you sure you want to change the base?
Distance sensors #97
Conversation
…y setting camera pivot position
TeamCode/src/main/java/com/kuriosityrobotics/firstforward/robot/modules/ModuleThread.java
Outdated
Show resolved
Hide resolved
if (module.isOn()) { | ||
module.onClose(); | ||
} | ||
} | ||
|
||
commonPool().shutdown(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it does anything, but it's supposed to shut down our thread pool used for asynch sensors (we just use the common pool for now--probably a bad idea but it didn't cause any problems). was a fix for slow stop times (might be placebo but is good practise anyway)
|
||
robot.getTelemetryDump().update(); | ||
moduleUpdateTimes = aTime; | ||
updateDuration = SystemClock.elapsedRealtime() - overallStart; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why'd we remove update times :((
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the overall modulethread update time isn't super relevant anymore.
TeamCode/src/main/java/com/kuriosityrobotics/firstforward/robot/modules/ModuleThread.java
Show resolved
Hide resolved
break; | ||
} | ||
|
||
Double[] pose; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why can't we use primitive types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does some clown shit with null Doubles
TeamCode/src/main/java/com/kuriosityrobotics/firstforward/robot/sensors/Odometry.java
Show resolved
Hide resolved
@@ -37,32 +35,43 @@ | |||
theKalmanFilter = new ExtendedKalmanFilter(0, 0, 0); | |||
} | |||
|
|||
private final HashMap<String, AsynchSensor> sensors; | |||
private final HashSet<AsynchProcess> sensors; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why can't this be a set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AsynchProcess used to contain the process name, but now asynchprocess wraps a module so it doesn't need it in a map
TeamCode/src/main/java/com/kuriosityrobotics/firstforward/robot/sensors/SensorThread.java
Show resolved
Hide resolved
TeamCode/src/main/java/com/kuriosityrobotics/firstforward/robot/util/Constants.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some things
.