Skip to content
This repository has been archived by the owner on Apr 23, 2023. It is now read-only.

Distance sensors #97

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Distance sensors #97

wants to merge 17 commits into from

Conversation

chop0
Copy link
Contributor

@chop0 chop0 commented Apr 5, 2022

.

@chop0 chop0 requested a review from e3l April 7, 2022 08:18
if (module.isOn()) {
module.onClose();
}
}

commonPool().shutdown();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it does anything, but it's supposed to shut down our thread pool used for asynch sensors (we just use the common pool for now--probably a bad idea but it didn't cause any problems). was a fix for slow stop times (might be placebo but is good practise anyway)


robot.getTelemetryDump().update();
moduleUpdateTimes = aTime;
updateDuration = SystemClock.elapsedRealtime() - overallStart;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why'd we remove update times :((

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the overall modulethread update time isn't super relevant anymore.

break;
}

Double[] pose;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can't we use primitive types

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does some clown shit with null Doubles

@@ -37,32 +35,43 @@
theKalmanFilter = new ExtendedKalmanFilter(0, 0, 0);
}

private final HashMap<String, AsynchSensor> sensors;
private final HashSet<AsynchProcess> sensors;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can't this be a set

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AsynchProcess used to contain the process name, but now asynchprocess wraps a module so it doesn't need it in a map

Copy link
Member

@sharkree sharkree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some things

@chop0 chop0 force-pushed the distance-sensors branch from eb139c5 to ab1856a Compare April 8, 2022 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants