Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cross-references to classes in Sphinx doc #195

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Fix cross-references to classes in Sphinx doc #195

merged 2 commits into from
Oct 20, 2023

Conversation

RemiLehe
Copy link
Member

The cross-references to classes used an incorrect syntax.

Documentation from the development branch:
Screenshot 2023-10-18 at 4 18 58 PM

Documentation with this PR:
Screenshot 2023-10-18 at 4 17 48 PM

@RemiLehe RemiLehe requested a review from AngelFP October 18, 2023 23:20
AngelFP
AngelFP reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@AngelFP AngelFP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Now that I see this, I would also suggest removing an instance of ... since it's redundant (see suggestions in comments).

lasy/profiles/combined_profile.py Outdated Show resolved Hide resolved
lasy/profiles/combined_profile.py Outdated Show resolved Hide resolved
@AngelFP AngelFP added documentation Improvements or additions to documentation bug Something isn't working labels Oct 19, 2023
@RemiLehe @AngelFP
Apply suggestions from code review
6b47a98 
Co-authored-by: Ángel Ferran Pousa <[email protected]>
@RemiLehe RemiLehe enabled auto-merge (squash) October 19, 2023 13:12
@RemiLehe RemiLehe requested a review from AngelFP October 19, 2023 13:32
@RemiLehe
Copy link
Member Author

Thanks for the review! I incorporated the suggested changes.

@RemiLehe RemiLehe merged commit 8aec692 into LASY-org:development Oct 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AngelFP AngelFP AngelFP approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RemiLehe @AngelFP