Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show progress bar in propagate #196

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

RemiLehe
Copy link
Member

The propagate function can potentially take a long time (if the grid is large) ; this PR changes the code so that the propagate function shows the progress bar:

Screenshot 2023-10-20 at 12 08 27 PM

Copy link
Member

@hightower8083 hightower8083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but one little question: could you check how this will look in methods with many propagations, e.g. gerchberg_saxton_algo. I'd imagine having many tens of dead bars might appear bit ugly, so an option to turn them off might be helpful.

@RemiLehe RemiLehe force-pushed the show_progress_propagator branch from 36872f5 to 9e65b67 Compare October 26, 2023 17:21
@RemiLehe
Copy link
Member Author

Ok, sounds good. I have made the progress bar optional and turned it off in the Gerschberg-Saxton function.

Copy link
Member

@hightower8083 hightower8083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Member

@hightower8083 hightower8083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@RemiLehe RemiLehe merged commit 17d34ff into LASY-org:development Oct 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants