-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show progress bar in propagate
#196
Show progress bar in propagate
#196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, but one little question: could you check how this will look in methods with many propagations, e.g. gerchberg_saxton_algo
. I'd imagine having many tens of dead bars might appear bit ugly, so an option to turn them off might be helpful.
36872f5
to
9e65b67
Compare
for more information, see https://pre-commit.ci
Ok, sounds good. I have made the progress bar optional and turned it off in the Gerschberg-Saxton function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
The
propagate
function can potentially take a long time (if the grid is large) ; this PR changes the code so that thepropagate
function shows the progress bar: