Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show method to visualize the laser #203

Merged
merged 6 commits into from
Nov 3, 2023

Conversation

RemiLehe
Copy link
Member

@RemiLehe RemiLehe commented Oct 26, 2023

This addresses #183. This adds a basic plotting capability (useful e.g. to make sure that the laser is fully inside the box, before dumping to disk).
For more advanced plotting, the user should probably dump the laser to file, and then use openPMD-viewer.

I also made use of this method in the tutorial:
Screenshot 2023-10-26 at 11 10 29 AM

@RemiLehe RemiLehe requested a review from MaxThevenet October 26, 2023 18:22
lasy/laser.py Outdated Show resolved Hide resolved
lasy/laser.py Outdated Show resolved Hide resolved
@RemiLehe RemiLehe requested a review from AngelFP November 1, 2023 12:57
@hightower8083
Copy link
Member

do you think we could have here some kind of envelope=True option and in the case of False show the carrier-frequency resolved field from get_full_field?

Copy link
Member

@AngelFP AngelFP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RemiLehe, thanks for this.

Overall it looks good to me, and it makes me think again that we should make the Grid a smarter class (e.g., so that it knows its dimensions, extent, etc.). It is otherwise quite cumbersome to work with it.

@MaxThevenet
Copy link
Contributor

@hightower8083 I would be in favor of only supporting the envelope in general, and avoid the carrier frequency, as it does not bring more information but is much more expensive. It's not a strong opinion, would be happy to hear everyone's thoughts.

@RemiLehe
Copy link
Member Author

RemiLehe commented Nov 3, 2023

Yes, we can discuss this in the next meeting, and, if needed, do a follow-up PR. For now, since this is approved, I will merge.

@RemiLehe RemiLehe merged commit 74a5d39 into LASY-org:development Nov 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants