-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add show
method to visualize the laser
#203
Conversation
do you think we could have here some kind of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RemiLehe, thanks for this.
Overall it looks good to me, and it makes me think again that we should make the Grid
a smarter class (e.g., so that it knows its dimensions, extent, etc.). It is otherwise quite cumbersome to work with it.
@hightower8083 I would be in favor of only supporting the envelope in general, and avoid the carrier frequency, as it does not bring more information but is much more expensive. It's not a strong opinion, would be happy to hear everyone's thoughts. |
Yes, we can discuss this in the next meeting, and, if needed, do a follow-up PR. For now, since this is approved, I will merge. |
This addresses #183. This adds a basic plotting capability (useful e.g. to make sure that the laser is fully inside the box, before dumping to disk).
For more advanced plotting, the user should probably dump the laser to file, and then use openPMD-viewer.
I also made use of this method in the tutorial: