Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long Data Profile: Optional Phase #212

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Dec 8, 2023

The phase argument is documented as optional, but currently required. This makes it optional in the implementation.

Alternatively, we can also change the doc string - let me know what you prefer :)

The phase argument is documented as optional, but currently
required. This makes it optional in the implementation.
@ax3l ax3l added the bug Something isn't working label Dec 8, 2023
@ax3l ax3l added documentation Improvements or additions to documentation cleaning Code cleaning and removed bug Something isn't working labels Dec 8, 2023
@RemiLehe RemiLehe merged commit 0cf9cac into LASY-org:development Dec 11, 2023
6 checks passed
@ax3l ax3l deleted the topic-phase-optional branch December 11, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Code cleaning documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants