Add axiparabola #254
Merged
Add axiparabola #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
for more information, see https://pre-commit.ci
RemiLehe
commented
Aug 1, 2024
| @@ -0,0 +1,241 @@ | |||
| { | |||
There was a problem hiding this comment.
It is easier to review this file by looking at the rendering here:
https://lasydoc--254.org.readthedocs.build/en/254/tutorials/axiparabola.html
MaxThevenet
reviewed
Aug 5, 2024
MaxThevenet
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the axiparabola as a new optical element.
This PR also adds an automated test, as well as a tutorial in the documentation showing how to create a flying-focus laser with an axiparabola.
Both the automated test and the automated test check that the field of the laser remains high over several Rayleigh lengths. The automated tests checks this automatically (with
assertstatements), while the tutorial checks this visually (with plots).The tutorial can be visualized here: https://lasydoc--254.org.readthedocs.build/en/254/tutorials/axiparabola.html