Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing properties to Sinopia vocabulary documentation/specification #2859

Closed
michelleif opened this issue Jul 17, 2021 · 8 comments · Fixed by #3282
Closed

add missing properties to Sinopia vocabulary documentation/specification #2859

michelleif opened this issue Jul 17, 2021 · 8 comments · Fixed by #3282
Assignees

Comments

@michelleif
Copy link
Contributor

michelleif commented Jul 17, 2021

at sinopia.io/vocabulary, the following properties are missing. add them, along with one-line description:

  1. https://sinopia.io/vocabulary/hasResourceAttributes (NOTE: https://sinopia.io/vocabulary/hasResourceAttribute is present, but is a different property)
  2. http://sinopia.io/vocabulary/hasResourceId
  3. http://sinopia.io/vocabulary/hasLookupAttributes
  4. http://sinopia.io/vocabulary/hasAuthority
  5. http://sinopia.io/vocabulary/hasRemarkUrl
  6. http://sinopia.io/vocabulary/hasDefault
@michelleif michelleif added the bug Something isn't working label Jul 17, 2021
@michelleif michelleif changed the title Sinopia vocabulary is missing properties add missing properties to Sinopia vocabulary documentation/specification Aug 3, 2021
@michelleif
Copy link
Contributor Author

do this in conjunction with LD4P/sinopia#311

@ndushay
Copy link
Contributor

ndushay commented Oct 29, 2021

@jermnelson if there is a document explaining how to get these Vocab entries served out at sinopia.io, please point me to it. If there isn't a document, can you spend 3 min writing the steps as a comment here and I'll turn it into a document?

Thanks.

@ndushay
Copy link
Contributor

ndushay commented Oct 29, 2021

@michelleif here is what I've got for initial descriptions. If you don't like them, I can help you do a pull request to change them, if you don't already know how:

  • hasAuthority: "An authority associated with a lookup"
  • hasDefault: "Default value(s) specific to a property"
  • hasLookupAttributes: "Attributes for a lookup"
  • hasRemarkUrl: "The property's remark as a URL."
  • hasResourceAttributes: "Attributes for a resource"
  • hasResourceId: "The resource's Template ID, e.g., ld4p:RT:bf2:Title:AbbrTitle"

@ndushay
Copy link
Contributor

ndushay commented Oct 29, 2021

More missing:

  • hasUriAttributes: "Attrbutes for a URI"
  • hasLiteralAttributes: "Attrbutes for a literal"
  • hasUri: "URI"
  • PropertyTemplate: (had no description) "Class for a property template"

@justinlittman
Copy link
Contributor

No need to publish -- it's part of the app: https://github.com/LD4P/sinopia_editor/blob/main/src/components/App.jsx#L195-L207

@ndushay
Copy link
Contributor

ndushay commented Oct 30, 2021

Does that get it out to, e.g. "https://development.sinopia.io/vocabulary" ? When the app is deployed?

No need to publish -- it's part of the app: https://github.com/LD4P/sinopia_editor/blob/main/src/components/App.jsx#L195-L207

@justinlittman
Copy link
Contributor

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants