Update Vocab.js #3282
Merged
Update Vocab.js #3282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndushay
force-pushed
the
update-vocab
branch
2 times, most recently
from
90db8af to
d55c908
Compare
ndushay
commented
Nov 1, 2021
| url: "http://sinopia.io/vocabulary/ResourceTemplate", | ||
| }, | ||
| Uri: { | ||
| description: "Class for a URI template", | ||
| url: "http://sinopia.io/vocabulary/Uri", |
There was a problem hiding this comment.
it seems ... wrong ... to have a URI as a sinopia vocabulary ... isn't URI already defined?
There was a problem hiding this comment.
Dunno, but this vocab is primarily for internal use so not overwhelmingly concerned.
justinlittman
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Hold until it's clear what the vocab URI should be for issues #2907 and #2889]Why was this change made?
Fixes #2859
@michelleif I added everything I could find that was missing - it was a much longer list than in issue #2859. Some comments below.
@michelleif I also think you can probably do the PRs for this in the future. :-)
Also related to #2907 and #2889
How was this change tested?
Which documentation and/or configurations were updated?