Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack overflow in release build of swww #240

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Conversation

iynaix
Copy link
Contributor

@iynaix iynaix commented Mar 23, 2024

Fixes #239. I'm not sure if this is the correct fix, but it solves it for me.

@LGFae
Copy link
Owner

LGFae commented Mar 23, 2024

Yeah, this looks perfect. Thanks.

@LGFae LGFae merged commit dcf0d4e into LGFae:main Mar 23, 2024
9 checks passed
@petarvujovic98
Copy link

@LGFae When can we expect this to be included in a release? I'm using this package via nixpkgs so creating a release and updating the nix package would be great. Thanks for the great tool

@LGFae
Copy link
Owner

LGFae commented Apr 7, 2024

I wanted to solve #233 before releasing a new version, but that's proving to be difficult.

I am planning on fixing #262 and merging #266 before releasing a new version.

EDIT: just finished doing that. I will wait a week to see if anyone finds a pressing issue and release the next version probably next weekend if there are no problems.

@iynaix
Copy link
Contributor Author

iynaix commented Apr 8, 2024

@LGFae When can we expect this to be included in a release? I'm using this package via nixpkgs so creating a release and updating the nix package would be great. Thanks for the great tool

FWIW I use NixOS too, I have this patch applied via an overlay:

  nixpkgs.overlays = [
    (_: prev: {
      swww = prev.swww.overrideAttrs (o: rec {
        src = prev.fetchFromGitHub {
          owner = "LGFae";
          repo = "swww";
          rev = "dcf0d4e481b13c19f2490d730cb45c03d4e8b77b";
          hash = "sha256-HfK9AOTsTO0JnrD6e6g/LtwukOjDhf9ZeC6/TmNZqDc=";
        };

        cargoDeps = prev.rustPlatform.importCargoLock { lockFile = src + "/Cargo.lock"; };
      });
    })
  ];

@petarvujovic98
Copy link

@LGFae @iynaix Thank you both for the info. Much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack Overflow in release build
3 participants