Manual serializer #299
Merged
Manual serializer #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had separated them a long time ago in order to send them in a pipeline. However, that turned out to have the issue of the animation not starting as soon as possible after the transition was finished, so we began sending both one after the other in two messages. That is rather wasteful, so this commit merges everything together in one big request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handwritten serializer and deserializar. It is faster, using the same amount of memory.
We are now using a shared memory file to transfer large amounts of data between the daemon and the client. This makes communication between the two faster still.
Finally, we've merged the Image and Animation requests into a single one, halving the amount of round-trips necessary to send in an animated image.