Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vertical monitor transitions & 'failed to load cache' errors #389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nynxz
Copy link

@Nynxz Nynxz commented Jan 17, 2025

Fixed Issues:

  • Transitions on vertical monitor's were having issues
  • [WARN] failed to load cache: there is already another swww process running errors on wallpaper changes

Discussion: Wallpaper changing animations do not work on vertical monitor

have not written rust,
I am not sure if this causes issues with 56928f7

@LGFae
Copy link
Owner

LGFae commented Jan 17, 2025

I believe the problem with this is that it wouldn't reload the image if the output's configuration changed. That was the original reason for that commit.

@LGFae
Copy link
Owner

LGFae commented Jan 17, 2025

I also do not understand how this could possibly be the solution to #386. There seems to be a more fundamental issue we have to address.

@Nynxz
Copy link
Author

Nynxz commented Jan 26, 2025

0001-2677.mp4

Not sure, the issue did not exist before 56928f7
I feel it would be better to remove the problem code and try fix what was intended by 56928f7 (refreshing when monitor input changes) a different way
over trying to fix the issue 56928f7 caused. I.e listening to actual wayland events, rather than constantly polling for whether the 'surface has changed', which is what it seems like its doing currently, and causing a memory leak.

there is also a memory leak if transitions get overwritten midway through (changing the wallpaper too quickly)
but that is a separate issue to these ones.

@GeodeArc
Copy link

It seems to be working now (after upgrading to Hyprland 47), so I closed the original. Unfortunately so many things broke in hyprland 47 for me that I will be switching back to 46 for now, meaning I have to live with the animations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants