Feat/naga fix bls wasm cleanup #776
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… usage - Also send `nodeSet` to `sign_session_key` endpoint as it is required - Fixed typo on name of wasm method for `ecdsaCombineAndVerify` (was previously unused)
…a-dev-support-with-rust-toolchain add rust-toolchain.toml so we autoinstall some necessary rust stuff
…a-add-naga-dev-support feat: add naga dev support
…ithub.com/LIT-Protocol/js-sdk into feature/lit-4124-js-sdk-naga-fix-bls-wasm
- **Added**: New file defining: - union type for cryptographic signature types. - interface for standardized HTTP responses. - Partial interface for raw ECDSA message data. - **Updated**: now exports all types from . **Implications**: - Enables consistent usage of HTTP response and signature types across the application. - Improves maintainability and type safety for API client implementations.
…les and internal documentation (#1234)<details><summary>Difference analysis</summary>Changes made:- Removed the import of `PKPSignShare`- Removed the export of `SuccessNodePromises` from types- Removed commented example output blocks- Removed an internal console.log statementThe changes are primarily cleanup and do not alter functionality.</details>
…esSignatureShares` as deprecated
- **Added**: Optional fields and to the interface. - **Updated**: Moved to a new position and made it optional (). - **Removed**: The original line was refactored for better structure. **Implications**: - Provides flexibility by allowing certain fields to be undefined or null. - Improves structure for handling edge cases or incomplete data in
…add `bls.spec.ts` unit tests
…ains a nested structure
Ansonhkg
changed the base branch from
feature/lit-4124-js-sdk-naga-fix-bls-wasm
to
feature/lit-3748-naga
Alright, so I'm trying to generate a commit message based on the provided diff file. Let me go through this step by step. First, I look at the diff file. It shows changes made to the file `get-signatures.ts`. The modifications start at line 105 in that file. Comparing the before and after versions, I notice a few key things. In the original code, there were lines where `publicKey` and `dataSigned` were being set using `mostCommonString`. These values were also using optional chaining with `?? ''`, which means if they were null or undefined, an empty string would be used as a fallback. But in the updated version, these assignments are moved to earlier lines where `_publicKey` and `_dataSigned` are declared, and now there's an additional check: if either is missing, an error is thrown. So, the commit message needs to capture the essence of this change. The type here should be 'feat' because it adds a new error handling mechanism. The scope is clearly 'helpers' since that's where the file is located. For the summary, I need to succinctly explain what changed: ensuring both public key and data signed are present by throwing an error if either is missing. Putting this all together, the message should be structured as `<type>(<scope>): <summary>`, which becomes 'feat(helpers): Ensure public key and data signed are present in combined signature.' </think> feat(helpers): Ensure public key and data signed are present in combined signature
Okay, I need to help the user generate a commit message based on the provided diff and history. Let me look at this step by step. First, I'll examine the diff content. The file changed is `packages/wasm/rust/src/bls.rs`. Looking at the changes, it seems that a block of code has been removed between lines 11 and 16 of this file. Specifically, an enum called `BlsVariant` is being deleted. The context provided includes prior commit messages. The last one was about removing a structure, so I should follow a similar pattern here. Since the task now involves removing an enum, that aligns well with using 'remove' as the type of change and indicating it's in the scope of the Rust package. I'll form the message accordingly: '<type>' would be 'remove', the '<scope>' is 'rust', and the summary is what is being removed, which is the BlsVariant enum. Putting that together gives a clear and concise commit message that accurately reflects the change made. </think> The provided code diff shows that the `BlsVariant` enum has been removed from the file. This should be reflected in the commit message. Step-by-step explanation: 1. Identify the type of change (addition, removal, modification). 2. Determine the scope or component affected. 3. Provide a clear and concise summary of the change. Based on this: remove(rust): BlsVariant enum
Alright, I'm faced with generating a commit message based on the provided diff. Let me go through this step by step.
First, I look at the files changed. The file in question is `index.ts` within the `packages/wasm/src/` directory. So, the scope of the change is likely 'wasm' since that's part of the path.
Next, I examine the specific changes in the diff. There are a few key things here:
1. **Imports Removed:** The import line for `BlsVariant` from `'./pkg/wasm-internal'` has been removed.
2. **Exports Adjusted:** Similarly, `BlsVariant` is no longer being exported from this file.
3. **Comments Deleted:** In two function definitions (`blsCombine`, `blsDecrypt`), the parameter comments for `{BlsVariant} variant` have been removed.
Putting this together, it seems that the `BlsVariant` type has been either moved elsewhere or is no longer needed in this context. The changes are about removing unnecessary elements from this file to clean up the codebase.
Considering commit message conventions, the general structure should be `<type>(<scope>): <summary>`. For this case, since it's a removal, `remove` would be an appropriate type. The scope is clearly 'wasm'.
So, the summary part should articulate that we're removing the BlsVariant type from index.ts.
Putting it all together: `remove(wasm): Remove BlsVariant type from index.ts`
</think>
The changes involve removing imports and exports of `BlsVariant` as well as its parameter comments in function definitions. This indicates removal or deprecation of the `BlsVariant` type from the current package. The scope is within 'wasm' based on the file path.
```text
remove(wasm): Remove BlsVariant type from index.ts
```
…8d2168c025d7` branch: rc-naga-2025-01-23
…45a598a98d2168c025d7`" This reverts commit ab73610.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Test
Command
E2E
BLS unit test
❗️NOTE
This is tested against (ordered by date as this page)
ed401dc438b4834d5d7883571e8edf8aa5d4e054(latest working commit)8052b7800bc4bc121dbc3de951b6396442282d65f8047310fd4ac97ac01ff07a7cd1213808a3396e60318791258d273df8209b912b386680d25d0df3👈 Everyone else/InternalDev will be on this.❌ It's NOT compatible with the latest commit in the
developbranch, specifically this commit/pr❌ This dose not work against
naga-devas we are unsure which commit was used to deploy.❌ authSig (ETH, SOL, Cosmos) encryption/decryption does not work.