-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separating generic systems and site specific systems #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming system seems reasonable although I'm not sure if lack-of-site means we should use the term "generic". I'd prefer "nosite"
Also, it looks like the move for (edit: I was wrong about that, there is no longer a HPECray-zen3-MI250X-Slingshot directory)HPECray-zen3-MI250X-Slingshot
is incomplete (more on that in specific comment).
I can live with nosite. I hope we will be able to do per-site directories in the long run; would the generic/nosite specs live in the base directory then, or in the generic/nosite directory? |
The latter: in the nosite directory(which is I think how things are organized now). If I understand correctly, by the "base" directory you mean something like |
Sounds good. I renamed generic to nosite. When we can do nested directories, we will plan to have SiteName directories, and a nosite directory for the nosite-* systems. |
Site specific systems are named site-name-system, and contain site specific details about package versions and locations.
Generic systems define the bare minimum for Benchpark to work, and are intended to be a starting point of a system specification for a specific hardware, that can be built upon to describe a site specific system.