Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separating generic systems and site specific systems #116

Merged
merged 11 commits into from
Jan 20, 2024
Merged

Conversation

pearce8
Copy link
Collaborator

@pearce8 pearce8 commented Jan 19, 2024

Site specific systems are named site-name-system, and contain site specific details about package versions and locations.

Generic systems define the bare minimum for Benchpark to work, and are intended to be a starting point of a system specification for a specific hardware, that can be built upon to describe a site specific system.

@github-actions github-actions bot added docs Improvements or additions to documentation configs New or modified system config labels Jan 19, 2024
Copy link
Collaborator

@scheibelp scheibelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming system seems reasonable although I'm not sure if lack-of-site means we should use the term "generic". I'd prefer "nosite"

Also, it looks like the move for HPECray-zen3-MI250X-Slingshot is incomplete (more on that in specific comment). (edit: I was wrong about that, there is no longer a HPECray-zen3-MI250X-Slingshot directory)

@github-actions github-actions bot added the ci Involving Project CI & Unit Tests label Jan 19, 2024
@pearce8
Copy link
Collaborator Author

pearce8 commented Jan 20, 2024

The naming system seems reasonable although I'm not sure if lack-of-site means we should use the term "generic". I'd prefer "nosite"

Also, it looks like the move for HPECray-zen3-MI250X-Slingshot is incomplete (more on that in specific comment).

I can live with nosite. I hope we will be able to do per-site directories in the long run; would the generic/nosite specs live in the base directory then, or in the generic/nosite directory?

@scheibelp
Copy link
Collaborator

I hope we will be able to do per-site directories in the long run; would the generic/nosite specs live in the base directory then, or in the generic/nosite directory?

The latter: in the nosite directory(which is I think how things are organized now).

If I understand correctly, by the "base" directory you mean something like HPECray-zen3-MI250X-Slingshot, which no longer exists in this PR - I think we should remove those (i.e. keep things as they are now in this PR).

@pearce8
Copy link
Collaborator Author

pearce8 commented Jan 20, 2024

I hope we will be able to do per-site directories in the long run; would the generic/nosite specs live in the base directory then, or in the generic/nosite directory?

The latter: in the nosite directory(which is I think how things are organized now).

If I understand correctly, by the "base" directory you mean something like HPECray-zen3-MI250X-Slingshot, which no longer exists in this PR - I think we should remove those (i.e. keep things as they are now in this PR).

Sounds good. I renamed generic to nosite. When we can do nested directories, we will plan to have SiteName directories, and a nosite directory for the nosite-* systems.

@pearce8 pearce8 marked this pull request as ready for review January 20, 2024 02:18
@pearce8 pearce8 requested a review from scheibelp January 20, 2024 02:18
@pearce8 pearce8 merged commit df04c06 into develop Jan 20, 2024
7 checks passed
@pearce8 pearce8 deleted the configs/tioga branch January 20, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Involving Project CI & Unit Tests configs New or modified system config docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants