Kripke comm cali #334
Draft
Kripke comm cali #334
+58
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfhaque
reviewed
Aug 15, 2024
| @@ -47,7 +47,11 @@ ramble: | |||
| software: | |||
| packages: | |||
| hypre-omp: | |||
| pkg_spec: [email protected] +mpi+openmp+mixedint~fortran{modifier_spack_variant} | |||
| # spack_spec: [email protected] +mpi+openmp+mixedint~fortran{modifier_spack_variant} | |||
There was a problem hiding this comment.
@gracenansamba It would be good to move the amg2023 changes to its own PR
#318
| @@ -31,7 +33,8 @@ class Amg2023(CMakePackage, CudaPackage, ROCmPackage): | |||
| depends_on("caliper", when="+caliper") | |||
| depends_on("adiak", when="+caliper") | |||
| depends_on("hypre+caliper", when="+caliper") | |||
| depends_on("[email protected]:") | |||
| # depends_on("[email protected]:") | |||
There was a problem hiding this comment.
@gracenansamba It would be good to move the amg2023 changes to its own PR
#318
| @@ -18,6 +18,8 @@ class Hypre(BuiltinHypre): | |||
| "gcc": "gnu", | |||
| } | |||
|
|
|||
| version("3.1_comm_cali", branch="comm_cali", submodules=False, git="https://github.com/gracenansamba/hypre.git") | |||
There was a problem hiding this comment.
@gracenansamba It would be good to move the amg2023 changes to its own PR
#318
gracenansamba
force-pushed
the
kripke_comm_cali
branch
from
eb7b77b to
7419d6e
Compare
rfhaque
reviewed
Sep 16, 2024
added 2 commits
December 5, 2024 20:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Kripke PR, for review by Riyaz