-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] Testing Salmon/Openmp #391
base: develop
Are you sure you want to change the base?
Conversation
16f368a
to
406d7c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slabasan does it work on dynamic systems? Can you add a dynamic system dry run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added it now along with the application.py
. Need to confirm it's correct through github CI.
Description
Removing dependence on the Fujitsu compiler.
This PR works on ruby with legacy salmon, but needs testing on Fugaku. I had to remove
-stdin
from theapplication.py
, and I'm concerned this is required by Fugaku but not other systems. Here are the steps to reproduce with this branch:Then follow the steps in output
Stephanie TODO:
experiment.py
and verify generatedramble.yaml
with hand written one in this PRdynamic cts ruby
Generated
ramble.yaml
: Missing section forrt
workload, is the compiler correct?Dependencies: FIXME:Add a list of any dependencies.
Fixes issue(s): Part of #460
Type of Change
Checklist:
If adding/modifying a system:
system.py
file.github/workflows
If adding/modifying a benchpark:
application.py
and (maybe)package.py
under a new directoryfor this benchmark
section
If adding/modifying a experiment:
experiment.py
under existing directory for specific benchmarkIf adding/modifying core functionality:
.github/workflows
and.gitlab/ci
unit tests (if needed)