Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] Testing Salmon/Openmp #391

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Conversation

dyokelson
Copy link
Collaborator

@dyokelson dyokelson commented Oct 7, 2024

Description

Removing dependence on the Fujitsu compiler.

This PR works on ruby with legacy salmon, but needs testing on Fugaku. I had to remove -stdin from the application.py, and I'm concerned this is required by Fugaku but not other systems. Here are the steps to reproduce with this branch:

cd benchpark
. setup-env.sh
benchpark setup salmon/openmp RCCS-Fugaku-Fujitsu-A64FX-TofuD workspace

Then follow the steps in output

Stephanie TODO:

  • Create experiment.py and verify generated ramble.yaml with hand written one in this PR
  • Replace dry run with dynamic cts ruby
  • Add dry run for fugaku (new way)

Generated ramble.yaml: Missing section for rt workload, is the compiler correct?

ramble:
  applications:
    salmon-tddft:
      workloads:
        gs:
          experiments:
            salmon-tddft_gs_single_node_openmp_{n_nodes}:
              exclude: {}
              matrix: []
              variables:
                arch: OpenMP
                exercise: exercise_01_C2H2_gs
                experiment_setup: ''
                inp_file: C2H2_gs.inp
                n_nodes:
                - '1'
                n_ranks: '{processes_per_node} * {n_nodes}'
                omp_num_threads:
                - '12'
                processes_per_node:
                - '4'
              variants:
                package_manager: spack
              zips: {}
  config:
    deprecated: true
    spack_flags:
      concretize: -U -f
      install: --add --keep-stage
  include:
  - ./configs
  modifiers:
  - name: allocation
  - name: exit-code
  software:
    environments:
      salmon-tddft:
        packages:
        - salmon-tddft
    packages:
      salmon-tddft:
        compiler: default-compiler
        pkg_spec: salmon-tddft@master+openmp

Dependencies: FIXME:Add a list of any dependencies.

Fixes issue(s): Part of #460

Type of Change

  • { } Adding a system, benchmark, or experiment
  • {x} Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • {x} Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • { } Create a new directory for the system and a new system.py file
  • { } Add a new dry run unit test in .github/workflows
  • { } System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • {x} Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • {x} Configure an experiment
  • { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • { } Extend experiment.py under existing directory for specific benchmark
  • { } Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@github-actions github-actions bot added experiment New or modified experiment ci CI, unit tests, GitHub actions labels Oct 7, 2024
@dyokelson dyokelson mentioned this pull request Nov 27, 2024
4 tasks
@dyokelson dyokelson added the WIP A work-in-progress not yet ready to commit label Nov 27, 2024
@github-actions github-actions bot added system New or modified system config application labels Jan 15, 2025
@slabasan slabasan force-pushed the salmon-test branch 4 times, most recently from 16f368a to 406d7c3 Compare January 16, 2025 05:27
@slabasan slabasan requested review from jdomke and pearce8 January 17, 2025 21:56
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slabasan does it work on dynamic systems? Can you add a dynamic system dry run?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it now along with the application.py. Need to confirm it's correct through github CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI, unit tests, GitHub actions experiment New or modified experiment system New or modified system config WIP A work-in-progress not yet ready to commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants