Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding experiment class for gpcNet #430

Open
wants to merge 73 commits into
base: develop
Choose a base branch
from
Open

Conversation

august-knox
Copy link
Collaborator

@august-knox august-knox commented Nov 13, 2024

Description

Adding GPCNet benchmarks, network_test and network_load_test

Dependencies: None

Fixes issue(s): #322

Type of Change

  • {x} Adding a system, benchmark, or experiment
  • { } Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • { } Create a new directory for the system and a new system.py file
  • { } Add a new dry run unit test in .github/workflows
  • { } System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • {x} Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • {x} Configure an experiment
  • { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • {x} Extend experiment.py under existing directory for specific benchmark
  • {x} Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@august-knox august-knox requested a review from nhanford November 13, 2024 18:46
@github-actions github-actions bot added experiment New or modified experiment ci Involving Project CI & Unit Tests application New or modified application labels Nov 13, 2024
@pearce8 pearce8 added the ready for review Ready for review label Nov 14, 2024
@slabasan slabasan marked this pull request as draft December 12, 2024 04:39
@pearce8
Copy link
Collaborator

pearce8 commented Jan 6, 2025

@august-knox is this ready for review?

@nhanford please look at this PR. Looks like @august-knox could use help with FOMs.

@august-knox august-knox marked this pull request as ready for review January 9, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application New or modified application ci Involving Project CI & Unit Tests experiment New or modified experiment ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants