Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license verification CI check #516

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

scheibelp
Copy link
Collaborator

@scheibelp scheibelp commented Jan 3, 2025

I'm not clear what changed, but

  • Without this change - removing the pip cache for the license verification check - there can be a failure
  • I don't think we actually need to use any cache for license verification, because this check has no dependencies

Example of failure without this change: #515

This affects all PRs, e.g. if you look at commit 07295aa (the first commit in this PR, which just tried to reproduce the issue), that has a CI failure.

See also: https://github.com/actions/setup-python/issues/436

…ob with caching, it will apparently fail in some cases if nothing was cached
@github-actions github-actions bot added the ci CI, unit tests, GitHub actions label Jan 3, 2025
@scheibelp scheibelp changed the title [WIP] Reproduce license verification error Reproduce license verification error Jan 3, 2025
@scheibelp scheibelp changed the title Reproduce license verification error Fix license verification CI check Jan 3, 2025
@scheibelp scheibelp requested a review from pearce8 January 3, 2025 00:26
@pearce8 pearce8 merged commit fbfce03 into LLNL:develop Jan 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI, unit tests, GitHub actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants