Adds support for Corona to the llnl-cluster system

[ilumsden]

Description

This PR modifies the llnl-cluster system to also support Corona. This required a few Corona-specific tweaks to the LlnlCluster class, mainly because, unlike the other clusters associated with this system, Corona has AMD GPUs. Most changes relate to adding functions for injecting ROCm into the packages and compilers.

Dependencies: None

Fixes issue(s): None

Type of Change

• { } Adding a system, benchmark, or experiment
• {X} Modifying an existing system, benchmark, or experiment
• { } Documentation update
• { } Build/CI update
• { } Benchpark core functionality

Checklist:

If adding/modifying a system:

• {X} Create a new directory for the system and a new system.py file
• { } Add a new dry run unit test in .github/workflows
• { } System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

• { } Add a new application.py and (maybe) package.py under a new directory
  for this benchmark
• { } Configure an experiment
• { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
  section

If adding/modifying a experiment:

• { } Extend experiment.py under existing directory for specific benchmark
• { } Define a single node and multi-node experiments

If adding/modifying core functionality:

• { } Update docs
• { } Update .github/workflows and .gitlab/ci unit tests (if needed)

[pearce8]

@ilumsden thanks for this! There may be 2 solutions:

1. corona could be one of the llnl-cluster
2. it might need to be its own system.py

I think this largely depends on how we are implementing "provides" and "requires". Since corona has GPUs/rocm, it would need to "provide" rocm. @becker33, it would be good to have you weigh in here.