Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ramble version #523

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 0 additions & 60 deletions .github/workflows/run.yml
Original file line number Diff line number Diff line change
Expand Up @@ -261,26 +261,6 @@ jobs:
--disable-logger \
workspace setup --dry-run

- name: Dry run lammps/openmp with static Ruby
run: |
./bin/benchpark setup lammps/openmp LLNL-Ruby-icelake-OmniPath workspace/
. workspace/setup.sh
ramble \
--workspace-dir workspace/lammps/openmp/LLNL-Ruby-icelake-OmniPath/workspace \
--disable-progress-bar \
--disable-logger \
workspace setup --dry-run

- name: Dry run lammps/rocm with static Tioga
run: |
./bin/benchpark setup lammps/rocm LLNL-Tioga-HPECray-zen3-MI250X-Slingshot workspace/
. workspace/setup.sh
ramble \
--workspace-dir workspace/lammps/rocm/LLNL-Tioga-HPECray-zen3-MI250X-Slingshot/workspace \
--disable-progress-bar \
--disable-logger \
workspace setup --dry-run

- name: Dry run dynamic lammps/openmp on static Ruby
run: |
./bin/benchpark experiment init --dest=lammps-openmp lammps+openmp
Expand Down Expand Up @@ -315,16 +295,6 @@ jobs:
--disable-logger \
workspace setup --dry-run

- name: Dry run hpl/openmp with Caliper-topdown modifier on Magma
run: |
./bin/benchpark setup hpl/openmp --modifier=caliper-topdown LLNL-Magma-Penguin-icelake-OmniPath workspace/
. workspace/setup.sh
ramble \
--workspace-dir workspace/hpl/openmp/LLNL-Magma-Penguin-icelake-OmniPath/workspace \
--disable-progress-bar \
--disable-logger \
workspace setup --dry-run

- name: Dry run dynamic quicksilver-openmp on nosite-x86_64 with allocation modifier
run: |
./bin/benchpark experiment init --dest=quicksilver-openmp quicksilver+openmp +weak~single_node
Expand All @@ -336,16 +306,6 @@ jobs:
--disable-logger \
workspace setup --dry-run

- name: Dry run phloem/mpi-only on nosite-x86_64 with allocation modifier
run: |
./bin/benchpark setup phloem/mpi-only nosite-x86_64 workspace/
. workspace/setup.sh
ramble \
--workspace-dir workspace/phloem/mpi-only/nosite-x86_64/workspace \
--disable-progress-bar \
--disable-logger \
workspace setup --dry-run

- name: Dry run genesis/openmp with allocation modifier on Fugaku
run: |
./bin/benchpark setup genesis/openmp RCCS-Fugaku-Fujitsu-A64FX-TofuD workspace/
Expand Down Expand Up @@ -376,26 +336,6 @@ jobs:
--disable-logger \
workspace setup --dry-run

- name: Dry run qws/openmp with allocation modifier on Fugaku
run: |
./bin/benchpark setup qws/openmp RCCS-Fugaku-Fujitsu-A64FX-TofuD workspace/
. workspace/setup.sh
ramble \
--workspace-dir workspace/qws/openmp/RCCS-Fugaku-Fujitsu-A64FX-TofuD/workspace \
--disable-progress-bar \
--disable-logger \
workspace setup --dry-run

- name: Dry run qws/openmp with allocation modifier on nosite-x86_64
run: |
./bin/benchpark setup qws/openmp nosite-x86_64 workspace/
. workspace/setup.sh
ramble \
--workspace-dir workspace/qws/openmp/nosite-x86_64/workspace \
--disable-progress-bar \
--disable-logger \
workspace setup --dry-run

- name: Dry run dynamic saxpy/openmp with dynamic llnl-cluster ruby
run: |
./bin/benchpark system init --dest=ruby-system llnl-cluster cluster=ruby
Expand Down
4 changes: 2 additions & 2 deletions .gitlab/ci/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ legacy_test_run:
- ramble --workspace-dir . --disable-progress-bar --disable-logger
on --executor '{execute_experiment}' --where '{n_nodes} == 1'
# Analyze Experiments
- ramble --workspace-dir . --disable-progress-bar workspace analyze --always-print-foms --format json yaml text
- ramble --workspace-dir . --disable-progress-bar workspace analyze --format json yaml text
# Check Experiment Exit Codes
- cd -
- python ./.gitlab/ci/bin/exit-codes ./workspace/${LEGACY_BENCHMARK}/${LEGACY_VARIANT}/${LEGACY_ARCHCONFIG}/workspace/results.latest.json
Expand Down Expand Up @@ -155,7 +155,7 @@ test_run:
- ramble --workspace-dir . --disable-progress-bar --disable-logger
on --executor '{execute_experiment}' --where '{n_nodes} == 1'
# Analyze Experiments
- ramble --workspace-dir . --disable-progress-bar workspace analyze --always-print-foms --format json yaml text
- ramble --workspace-dir . --disable-progress-bar workspace analyze --format json yaml text
# Check Experiment Exit Codes
- cd -
- python ./.gitlab/ci/bin/exit-codes ./workspace/${BENCHMARK}-benchmark/${system_id}/workspace/results.latest.json
2 changes: 1 addition & 1 deletion checkout-versions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
# SPDX-License-Identifier: Apache-2.0

versions:
ramble: a838e7f # develop on 7/17/2024 (newer than 0.5.0 release)
ramble: f5970aa # develop on 1/08/2025 (newer than 0.5.0 release)
spack: 0b3b49b # develop-2024-06-28 (newer than 0.22.0 release)
2 changes: 1 addition & 1 deletion legacy/experiments/laghos/mpi-only/ramble.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ramble:
applications:
laghos:
workloads:
problem:
triplept:
env_vars:
variables:
n_nodes: ['1', '2', '4', '8', '16', '32', '64', '128']
Expand Down
2 changes: 1 addition & 1 deletion modifiers/caliper/modifier.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def add_mode(mode_name, mode_option, description):
)


class Caliper(SpackModifier):
class Caliper(BasicModifier):
"""Define a modifier for Caliper"""

name = "caliper"
Expand Down
2 changes: 1 addition & 1 deletion repo/genesis/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import sys

class Genesis(SpackApplication):
class Genesis(ExecutableApplication):
"""GENESIS package contains two MD programs (atdyn and spdyn), trajectory
analysis programs, and other useful tools. GENESIS (GENeralized-Ensemble
SImulation System) has been developed mainly by Sugita group in RIKEN-CCS.
Expand Down
2 changes: 1 addition & 1 deletion repo/salmon-tddft/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from ramble.appkit import *


class SalmonTddft(SpackApplication):
class SalmonTddft(ExecutableApplication):
"""Salmon-tddft benchmark"""
name = "salmon-tddft"

Expand Down