Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elf to externals #528

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Add elf to externals #528

wants to merge 8 commits into from

Conversation

pearce8
Copy link
Collaborator

@pearce8 pearce8 commented Jan 6, 2025

Description

Adding libelf to externals for El Capitan, setting to not buildable. @ilumsden please test.

Fixes issue(s): Spack builds gcc to build elf.

Type of Change

  • { } Adding a system, benchmark, or experiment
  • {X} Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • { } Create a new directory for the system and a new system.py file
  • { } Add a new dry run unit test in .github/workflows
  • { } System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • { } Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • { } Configure an experiment
  • { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • { } Extend experiment.py under existing directory for specific benchmark
  • { } Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@pearce8 pearce8 requested a review from ilumsden January 6, 2025 22:06
@pearce8 pearce8 self-assigned this Jan 8, 2025
@@ -4,11 +4,21 @@
# SPDX-License-Identifier: Apache-2.0

packages:
elf:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be elfutils not elf

papi:
buildable: false
externals:
- spec: [email protected]
prefix: /usr/tce/packages/papi/papi-6.0.0.1
unwind:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be libunwind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants