Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laghos GPU variants #539

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Laghos GPU variants #539

merged 7 commits into from
Jan 9, 2025

Conversation

august-knox
Copy link
Collaborator

Description

Updating Laghos with ROCm and CUDA variants

Dependencies: None

Fixes issue(s): None

Type of Change

  • { } Adding a system, benchmark, or experiment
  • {x} Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • { } Create a new directory for the system and a new system.py file
  • { } Add a new dry run unit test in .github/workflows
  • { } System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • { } Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • {x} Configure an experiment
  • {x} Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • {x} Extend experiment.py under existing directory for specific benchmark
  • {x} Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@august-knox august-knox requested a review from rfhaque January 9, 2025 20:38
@github-actions github-actions bot added experiment New or modified experiment application New or modified application labels Jan 9, 2025
Comment on lines 59 to 62
if self.spec.satisfies("+cuda"):
self.add_experiment_variable("arch", "CUDA")
elif self.spec.satisfies("+rocm"):
self.add_experiment_variable("arch", "HIP")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@august-knox Do we need the arch variable?

@github-actions github-actions bot added the ci Involving Project CI & Unit Tests label Jan 9, 2025
@rfhaque rfhaque merged commit b5384ff into develop Jan 9, 2025
8 checks passed
@rfhaque rfhaque deleted the experiment/laghosGPU branch January 9, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application New or modified application ci Involving Project CI & Unit Tests experiment New or modified experiment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants