Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update instructions for running on LLNL system in docs #540

Closed
wants to merge 1 commit into from

Conversation

slabasan
Copy link
Collaborator

@slabasan slabasan commented Jan 9, 2025

Description

FIXME:Provide a short summary of the change. Please also include relevant
motivation and context.

Dependencies: FIXME:Add a list of any dependencies.

Fixes issue(s): FIXME:Add list of relevant issues.

Type of Change

  • { } Adding a system, benchmark, or experiment
  • { } Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • { } Create a new directory for the system and a new system.py file
  • { } Add a new dry run unit test in .github/workflows
  • { } System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • { } Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • { } Configure an experiment
  • { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • { } Extend experiment.py under existing directory for specific benchmark
  • { } Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@slabasan slabasan added the WIP A work-in-progress not yet ready to commit label Jan 9, 2025
@github-actions github-actions bot added the docs Improvements or additions to documentation label Jan 9, 2025
Copy link
Collaborator

@dyokelson dyokelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no I didn't see you did this I also updated this page in another pr haha while I was in a meeting with Grace and Michael...it looks like mine encompasses these changes besides the system id thing which I think is okay for manual steps. Maybe we can just close this one.

@slabasan
Copy link
Collaborator Author

slabasan commented Jan 9, 2025

Captured in #541

@slabasan slabasan closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation WIP A work-in-progress not yet ready to commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants