Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using constants for left shift #94

Open
marco-biasion opened this issue Oct 18, 2024 · 2 comments · Fixed by #97
Open

Using constants for left shift #94

marco-biasion opened this issue Oct 18, 2024 · 2 comments · Fixed by #97
Assignees
@marco-biasion @MortezaRezaalipour @Francesco-Cos
Labels
planning > in progress This issue is being actively developed type > enhancement New feature or request

Comments

@marco-biasion
Copy link
Member

Add an option to allow the usage of constants only to shift points to the left.

Meaning:

  • the constants are not part of the model flow.
  • for each model, we apply a rewriting of the constants only to see the gain in error.
@marco-biasion marco-biasion added type > enhancement New feature or request planning > todo The development of this issue is paused or still has to start labels Oct 18, 2024
@marco-biasion marco-biasion added planning > in progress This issue is being actively developed and removed planning > todo The development of this issue is paused or still has to start labels Oct 18, 2024
@Francesco-Cos Francesco-Cos linked a pull request Oct 21, 2024 that will close this issue
94 using constants for left shift #97
Merged
Francesco-Cos added a commit that referenced this issue Oct 21, 2024
@Francesco-Cos
#94: Fixed specs reference for constants
6640a16
@marco-biasion
Copy link
Member Author

Now implementing optimization step with constants

@marco-biasion marco-biasion reopened this Oct 21, 2024
This was referenced Oct 21, 2024
Closed
Merged
Francesco-Cos added a commit that referenced this issue Oct 21, 2024
@Francesco-Cos
#94: Updated output file to include constants information
3c76402
Francesco-Cos added a commit that referenced this issue Oct 21, 2024
@Francesco-Cos
#94: Updated output file to include constants information
a4d3187
Francesco-Cos added a commit that referenced this issue Oct 25, 2024
@Francesco-Cos
#94: changed constants variable to use_constants boolean
a4cc3f8
marco-biasion added a commit that referenced this issue Oct 25, 2024
@marco-biasion
#94: updated how constants rewriting requirements are stored
73de655
marco-biasion added a commit that referenced this issue Oct 25, 2024
@marco-biasion
#94: added constants optimization logic
3db1f80
marco-biasion added a commit that referenced this issue Oct 25, 2024
@marco-biasion
#94: fix name extraction
c208c00
Francesco-Cos added a commit that referenced this issue Oct 31, 2024
@Francesco-Cos
#94: Fixed verilog naming in constant opimization; deleting unused im…
e79a517 
…port
marco-biasion added a commit that referenced this issue Oct 31, 2024
@marco-biasion
#94: added empty subgraph getter to annotatedGraph. fixed empty subgr…
fd56c4d 
…aph setting for constant optimization
Francesco-Cos added a commit that referenced this issue Oct 31, 2024
@Francesco-Cos
#94: merged main into 94
fdc6871
marco-biasion added a commit that referenced this issue Oct 31, 2024
@marco-biasion
#94: moved constant optimization logic to function, fixed minor problems
bd3c2cb
marco-biasion added a commit that referenced this issue Oct 31, 2024
@marco-biasion
#94: fixed resetting of original et in constant optimization
a27d457
@marco-biasion
Copy link
Member Author

marco-biasion commented Oct 31, 2024 •
edited
Loading

to: @MortezaRezaalipour
Logic implemented.
More testing is required.

to: @marco-biasion @Francesco-Cos
Remove debug stuff after verification.

Francesco-Cos added a commit that referenced this issue Nov 4, 2024
@Francesco-Cos
#94: Fixed an issue where an empty graph would be passed to the templ…
d77c2b7 
…ate manager
Francesco-Cos added a commit that referenced this issue Nov 4, 2024
@Francesco-Cos
#94 Added debug prints
aa7d96b
Francesco-Cos added a commit that referenced this issue Nov 4, 2024
@Francesco-Cos
#94: added fixed seed for graph extraction
426a358
Francesco-Cos added a commit that referenced this issue Nov 5, 2024
@Francesco-Cos
#94: Setting the seed in the template to avoid randomness in the solver
49bad1b
marco-biasion pushed a commit that referenced this issue Dec 13, 2024
@Francesco-Cos
#94: Fixed specs reference for constants
eaa33e2
marco-biasion pushed a commit that referenced this issue Dec 13, 2024
@Francesco-Cos
#94: Updated output file to include constants information
f0937c4
marco-biasion pushed a commit that referenced this issue Dec 13, 2024
@Francesco-Cos
#94: Updated output file to include constants information
b44897c
marco-biasion pushed a commit that referenced this issue Dec 13, 2024
@Francesco-Cos
#94: changed constants variable to use_constants boolean
07c4d82
marco-biasion added a commit that referenced this issue Dec 13, 2024
@marco-biasion
#94: updated how constants rewriting requirements are stored
8e295be
marco-biasion added a commit that referenced this issue Dec 13, 2024
@marco-biasion
#94: added constants optimization logic
f44dcb2
marco-biasion added a commit that referenced this issue Dec 13, 2024
@marco-biasion
#94: fix name extraction
f138223
marco-biasion pushed a commit that referenced this issue Dec 13, 2024
@Francesco-Cos
#94: Fixed verilog naming in constant opimization; deleting unused im…
e3e9619 
…port
marco-biasion added a commit that referenced this issue Dec 13, 2024
@marco-biasion
#94: added empty subgraph getter to annotatedGraph. fixed empty subgr…
0f3c3bd 
…aph setting for constant optimization
marco-biasion pushed a commit that referenced this issue Dec 13, 2024
@Francesco-Cos
#94: merged main into 94
ff9a426
marco-biasion added a commit that referenced this issue Dec 13, 2024
@marco-biasion
#94: moved constant optimization logic to function, fixed minor problems
7c0d86b
marco-biasion added a commit that referenced this issue Dec 13, 2024
@marco-biasion
#94: fixed resetting of original et in constant optimization
a02ab83
marco-biasion pushed a commit that referenced this issue Dec 13, 2024
@Francesco-Cos
#94: Fixed an issue where an empty graph would be passed to the templ…
b49e538 
…ate manager
marco-biasion pushed a commit that referenced this issue Dec 13, 2024
@Francesco-Cos
#94 Added debug prints
f25f1da
marco-biasion pushed a commit that referenced this issue Dec 13, 2024
@Francesco-Cos
#94: added fixed seed for graph extraction
28e0254
marco-biasion pushed a commit that referenced this issue Dec 13, 2024
@Francesco-Cos
#94: Setting the seed in the template to avoid randomness in the solver
194a8b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marco-biasion marco-biasion

@MortezaRezaalipour MortezaRezaalipour

@Francesco-Cos Francesco-Cos

Labels
planning > in progress This issue is being actively developed type > enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

94 using constants for left shift LP-RG/subxpat
3 participants
@marco-biasion @MortezaRezaalipour @Francesco-Cos