Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring SLSim - Create Galaxy class #227

Open
9 tasks
jacob-hjortlund opened this issue Aug 6, 2024 · 0 comments
Open
9 tasks

Refactoring SLSim - Create Galaxy class #227

jacob-hjortlund opened this issue Aug 6, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jacob-hjortlund
Copy link
Collaborator

Current Status

Currently the representation of a lens or source galaxy and a potential corresponding transient is spread across multiple different classes, including SourceBase, Lens, and Deflector.

Proposed Solution

Collect the responsibility of representing a galaxy and any related transient, including any necessary instantiation of composites, into a single Galaxy class. Instances of this class will be created by the Population class when samples are drawn from a Catalog, see #225 and #226 respectively. Additionally takes a callable mass_model and light_model to be instantiated from the provided galaxy parameters, see INSERT ISSUE HERE. This is part of the overall SLSim refactor, see #223.

To-Do List

  • Create Galaxy skeleton code.
  • Add ingestion of galaxy parameters.
  • Add ingestion of mass and light profiles.
  • Add ingestion / handling of provided / missing transient meta data.
  • Add method for providing galaxy / transient position.
  • Add method for providing galaxy / transient magnitude.
  • Add method for providing galaxy mass profile.
  • Add method for providing galaxy light profile.
  • Add unit tests.
@jacob-hjortlund jacob-hjortlund self-assigned this Aug 6, 2024
@jacob-hjortlund jacob-hjortlund added the enhancement New feature or request label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant