-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
U/jrbogart/gcr tutorial #166
Conversation
Overall I think it's fine. It won't continue to work as-is with the new changes to the connection to the production schema etc, so the mechanics will have to change a bit. Also need to add a link to the note book in the docs somewhere. Do we want a page in the docs for this? (or for DESC specific applications of the registry) |
Why won't the code here work as is? The connection to dataregistery happens with which ultimately makes a connection with where dr_schema is "lsst_desc_production" Yes, there should be a link to the notebook somewhere. It looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it should work. Need to double check testing it with the other PR.
Only comments relate to changes other PR will make relating to the schema to connect to
"source": [ | ||
"from dataregistry import DataRegistry\n", | ||
"from dataregistry.schema import DEFAULT_SCHEMA_PRODUCTION\n", | ||
"\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no DEFAULT_SCHEMA_PRODUCTION
anymore.
Options would be
- Import
DEFAULT_NAMESPACE
and connect toschema=f"{DEFAULT_NAMESPACE}_production"
- Specify or not the
DEFAULT_NAMESPACE
(but no need), and choosequery_mode="production"
to limit queries to production schema
"source": [ | ||
"### Dataset properties\n", | ||
"\n", | ||
"Recall that a `DataRegistry` instance has a member `Query` which provides all the query services, the principal one being the ability to ask for values of attributes of datasets, subject to one or more filters. If you haven't already, we recommend you take a look at the tutorial \"Getting started: Part 3 - Simple queries\" before proceeding further.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The query getting started is now "Part 2"
Demonstrate querying and accessing GCRCatalog-type catalogs via dataregistry.