Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataset status and move/delete/archive information #93

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

stuartmcalpine
Copy link
Collaborator

Update the dataset table to include:

  • status (-1: Invalid (e.g., copy data failed during creation), 1: Valid, 2: Archived, 3: deleted)
  • archive_date (When archived)
  • archive_path (Where archived to)
  • delete_date (when deleted)
  • delete_uid (who deleted)
  • move_date (when last move)

Any more?

@stuartmcalpine stuartmcalpine changed the base branch from main to u/stuart/reformat_registrar January 9, 2024 15:03
@JoanneBogart
Copy link
Collaborator

JoanneBogart commented Jan 16, 2024

I don't think these attributes (invalid, valid, archived, deleted) are exactly mutually exclusive. We might want to treat the status field as a bit mask up. Possible attributes of the dataset are
invalid (registration failed; there may be a file or files on disk but they are useless)
valid (successful registration and file(s) exist on disk)
backed up (successful registration and file(s) backed up)
deleted (no files on disk)
or maybe carry this a bit further and subdivide "valid" into orthogonal attributes "valid" (registration successful; no conclusion to be drawn about files can be found) and "live" (usable files exist on disk).
To be further discussed.

@stuartmcalpine
Copy link
Collaborator Author

Have updated the dataset status field to be a bitmask. So now any combination of valid, deleted, archived are available with a single digit.

Have also added a CI test for the functions.

@JoanneBogart
Copy link
Collaborator

Some questions:
Do we want a move_uid?
Does "deleted" imply "not valid"? What about "moved"?

Maybe we wait until these things are fully implemented before worrying too much about the exact form of these fields.
But in any case I think we should wait until the "reformat register" PR is approved (and merged with to version placeholder branch) before merging in this one.

Copy link
Collaborator

@JoanneBogart JoanneBogart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we implement additional features we might want to modify things a bit, but this looks fine for now.

@stuartmcalpine stuartmcalpine merged commit 5925305 into u/stuart/reformat_registrar Feb 9, 2024
8 checks passed
@stuartmcalpine stuartmcalpine deleted the u/stuart/dataset_status branch February 9, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants