Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaw notebook #173

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Add yaw notebook #173

merged 6 commits into from
Jan 14, 2025

Conversation

hangqianjun
Copy link
Contributor

Problem & Solution Description

Moving the YAW example notebook to here, adding yaw into the package list.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@hangqianjun hangqianjun requested a review from jlvdb January 10, 2025 17:13
@hangqianjun
Copy link
Contributor Author

Awaiting for updated fitsio package to run these tests.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (41aa8b7) to head (87393a0).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #173   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hangqianjun hangqianjun requested a review from ztq1996 January 13, 2025 10:53
@hangqianjun
Copy link
Contributor Author

@ztq1996 this PR now also includes fixes to the workflow files. The smoke tests run without problem.

Copy link
Contributor

@ztq1996 ztq1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hangqianjun hangqianjun merged commit b4ad4f4 into main Jan 14, 2025
10 checks passed
@hangqianjun hangqianjun deleted the add_yaw_notebook branch January 14, 2025 09:33
@hangqianjun hangqianjun restored the add_yaw_notebook branch January 14, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants