Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python 2 references #3

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

chrisinabox
Copy link
Contributor

Update setup to include wxPython packages and remove support for python 2
Update README to remove python 2 references

Cherry picked changes from b971ac0

…on 2

Update README to remove python 2 references
@chrisinabox
Copy link
Contributor Author

Ended up deleting the previous branch and cherry picking changes into a new branch as it became a little messy.

@sveinse
Copy link
Member

sveinse commented Nov 28, 2023

Should we also use this branch to clean the code for py2 stuff and make this a true py3 package? Today there are quite many constructs for maintaining py2 compatibility. Without py2, we can now start type annotating the code (and in the process discover loads of bugs).

@chrisinabox
Copy link
Contributor Author

Should we also use this branch to clean the code for py2 stuff and make this a true py3 package? Today there are quite many constructs for maintaining py2 compatibility. Without py2, we can now start type annotating the code (and in the process discover loads of bugs).

@sveinse I guess this is up to you as the project owner and the person who did most of the work updating the old implementation. Might be quite a deep rabbit hole.

As I have no idea how much work that might require it may be worth distributing the updated py3 version (with this change) and then having a more significant clean up and refactor effort?

@sveinse
Copy link
Member

sveinse commented Nov 28, 2023

As I have no idea how much work that might require it may be worth distributing the updated py3 version (with this change) and then having a more significant clean up and refactor effort?

The PR #2 makes it incompatible with py2 doesn't it? If it does, I agree with you. Let's just commit this simple fix to remove it as something that's installable with py2 and leave the big py2 removal refactor for later.

@chrisinabox
Copy link
Contributor Author

As I have no idea how much work that might require it may be worth distributing the updated py3 version (with this change) and then having a more significant clean up and refactor effort?

The PR #2 makes it incompatible with py2 doesn't it? If it does, I agree with you. Let's just commit this simple fix to remove it as something that's installable with py2 and leave the big py2 removal refactor for later.

I just did a preliminary test in a python 2 venv (windows). It seems that wxPython doesn't build properly with pip after 4.1.0. If using wxPython version 4.1.0 then it does at least appear to work (UI works, can open dictionaries without lots of errors).

@sveinse sveinse merged commit a8a82de into Laerdal:main Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants